add shop=scuba_diving

[mkoniecz]

What steps will reproduce the problem?

1. tag shop=scuba_diving node

What is the expected result?

it has an icon

What happens instead?

it has no icon

Please provide any additional information below. Attach a screenshot if possible.

​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dscuba_diving

over 1k uses

See https://josm.openstreetmap.de/ticket/18310 for more background

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-17 21:16:26 +0100 (Sun, 17 Nov 2019)
Revision:15528
Build-Date:2019-11-18 02:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15528 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 317 MB / 978 MB (146 MB allocated, but free)
Java version: 11.0.5+10-post-Ubuntu-2ubuntu116.04, Ubuntu, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.5+10-2ubuntu1~16.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-6
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ apache-commons (35092)
+ buildings_tools (35171)
+ continuosDownload (82)
+ ejml (35122)
+ geotools (35169)
+ imagery_offset_db (34908)
+ jts (35122)
+ log4j (34908)
+ measurement (35221)
+ reverter (35226)
+ todo (30306)

Validator rules:
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out

[mkoniecz]

I found ​https://github.com/bhousel/temaki/blob/master/icons/scuba_diving.svg from ​https://github.com/openstreetmap/iD/blob/master/data/presets/presets/shop/scuba_diving.json but scaled to 13x16 seems to be of dubious quality.

[mkoniecz]

from iD

[Klumbumbus]

We use that icon (slightly adjusted) already for sport=scuba_diving. In this case for the shop we maybe could use that internal icon, remove the blue background and change the black to the purple shop color (#ac39ac).

[Klumbumbus]

In 15536/josm:

fix #18337 - add shop=scuba_diving (icon derived from internal sport=scuba_diving icon, CC0 and PD licensed)