Modify

#18293 closed defect (fixed)

JOSM complains about crossing features although level tags are present

Reported by: selfishseahorse@… Owned by: Don-vip
Priority: normal Milestone: 19.11
Component: Core validator Version: tested
Keywords: level crossing Cc:

Description

It seems that the validator doesn't always take level=* tags into account. I get warnings about crossing highway/railway, railways, building/highway and building/railway, although the features have different level tags. However, it doesn't give a warning with highways having different level=* tags.

An example to reproduce this bug:

Draw two crossing lines. Tag one railway=rail + level=0 and the other highway=footway + level=1. The validator will give a warning. However, there will be no warning when both lines are tagged highway=footway.

Attachments (1)

Untitled.osm (999 bytes) - added by selfishseahorse@… 13 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 months ago by GerdP

I think level is used for indoor tagging. You probably meant layer?

comment:2 in reply to:  1 ; Changed 13 months ago by selfishseahorse@…

Replying to GerdP:

I think level is used for indoor tagging. You probably meant layer?

No, i mean level. I was improving a multi-level train station (46.94918,7.43798).

Note that the wiki also recommends using level for train stations:

"Ways in buildings (or similar structures like multilevel parking lots, shopping centers, airports, railway stations, some multilevel bridges and roads...) should be mostly described with level=* instead of layer." – https://wiki.openstreetmap.org/wiki/Key:layer

I finally added redundant layer tags as a workaround.

comment:3 in reply to:  2 Changed 13 months ago by selfishseahorse@…

Replying to selfishseahorse@…:

I finally added redundant layer tags as a workaround.

Which isn't unproblematical as there could be two or more layers on one single level.

comment:4 Changed 13 months ago by Don-vip

Owner: changed from team to selfishseahorse@…
Status: newneedinfo

Please attach a sample .osm file and the first three blocks of your status report.

Changed 13 months ago by selfishseahorse@…

Attachment: Untitled.osm added

comment:5 Changed 13 months ago by selfishseahorse@…

First blocks of status report:

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-01 23:59:01 +0100 (Fri, 01 Nov 2019)
Build-Date:2019-11-01 22:59:57
Revision:15492
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15492 en) Mac OS X 10.13.6
OS Build number: Mac OS X 10.13.6 (17G8037)
Memory Usage: 874 MB / 1820 MB (202 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69677504 1280x800
Maximum Screen Size: 1280x800
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DApplicationDirectory=${HOME}/Applications, -DAutosavedInformationDirectory=${HOME}/Library/Autosave Information, -DDesktopDirectory=${HOME}/Desktop, -DDownloadsDirectory=${HOME}/Downloads, -DMoviesDirectory=${HOME}/Movies, -DMusicDirectory=${HOME}/Music, -DPicturesDirectory=${HOME}/Pictures, -DSharedPublicDirectory=${HOME}/Public, -DSystemLibraryDirectory=/Library, -DSystemApplicationSupportDirectory=/Library/Application Support, -DSystemCachesDirectory=/Library/Caches, -DSystemApplicationDirectory=/Applications, -DSystemUserDirectory=/Users, -DUserHome=${HOME}, -DSandboxEnabled=true, -DLaunchModifierFlags=0, -DLaunchModifierFlagCapsLock=false, -DLaunchModifierFlagShift=false, -DLaunchModifierFlagControl=false, -DLaunchModifierFlagOption=false, -DLaunchModifierFlagCommand=false, -DLaunchModifierFlagNumericPad=false, -DLaunchModifierFlagHelp=false, -DLaunchModifierFlagFunction=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]
Dataset consistency test: No problems found

Plugins:
+ measurement (35051)
+ reverter (35084)
+ undelete (34977)
+ utilsplugin2 (35177)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: No default layer selected, choosing first layer.
- W: No default layer selected, choosing first layer.
Last edited 13 months ago by Don-vip (previous) (diff)

comment:6 Changed 13 months ago by Don-vip

Owner: changed from selfishseahorse@… to team
Status: needinfonew

comment:7 Changed 13 months ago by Don-vip

Keywords: level crossing added

comment:8 Changed 13 months ago by Don-vip

Milestone: 19.11
Owner: changed from team to Don-vip
Status: newassigned

comment:9 Changed 13 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15515/josm:

fix #18293 - handle level tag like layer in CrossingWays test

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.