#18292 closed defect (fixed)
[PATCH] JOSM Remote Control is missing all the options
Reported by: | taylor.smock | Owned by: | team |
---|---|---|---|
Priority: | major | Milestone: | 19.11 |
Component: | Core remotecontrol | Version: | |
Keywords: | regression | Cc: |
Description
If the RequestProcessor
class is not called before preferences are opened, then the static list for the panel isn't built.
This fix moves the initialization parts into a static method initialize
, which is called by both the RequestProcessor
and getPermissionPrefs
(but only if the PREF list is empty).
Attachments (1)
Change History (5)
by , 6 years ago
Attachment: | 18292.patch added |
---|
comment:3 by , 6 years ago
Its a regression caused by my previous patch. I don't believe that it is due to a difference between my patch and your modified patch, since it looked like the only difference was your use of Optional.ofNullable
instead of if (obj != null)
.
I didn't notice this since I have a plugin that called RequestHandler
in initialization, which initialized the static fields.
Initialize pref list for remote control (by manually calling RequestProcessor)