Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#18284 closed enhancement (fixed)

Add name:sr-Latn (Serbian name in Latin alphabet) to recognised language codes

Reported by: Stereo Owned by: Don-vip
Priority: normal Milestone: 19.11
Component: Core Version:
Keywords: template_report i18n Cc:

Description (last modified by Stereo)

What steps will reproduce the problem?

  1. Tag an object with name:sr=Лебдјелица
  2. Tag the object with name:sr-Latn=Lebdjelica

What is the expected result?

name:sr is shown as "Serbian" and name:sr-Latn is shown as "Serbian (Latin)"

What happens instead?

Only name:sr is recognised an a language in the list of tags.

Please provide any additional information below. Attach a screenshot if possible.

See also: https://taginfo.openstreetmap.org/keys/name%3Asr-Latn

It's common for objects to be tagged with both. Conversion from Cyrillic to Latin is lossless; conversion from Latin to Cyrillic is lossy.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-29 23:59:43 +0200 (Sun, 29 Sep 2019)
Build-Date:2019-09-29 22:01:37
Revision:15390
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15390 en_GB) Mac OS X 10.15.1
OS Build number: Mac OS X 10.15.1 (19B88)
Memory Usage: 1482 MB / 1820 MB (732 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69733632 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DApplicationDirectory=${HOME}/Applications, -DAutosavedInformationDirectory=${HOME}/Library/Autosave Information, -DDesktopDirectory=${HOME}/Desktop, -DDownloadsDirectory=${HOME}/Downloads, -DMoviesDirectory=${HOME}/Movies, -DMusicDirectory=${HOME}/Music, -DPicturesDirectory=${HOME}/Pictures, -DSharedPublicDirectory=${HOME}/Public, -DSystemLibraryDirectory=/Library, -DSystemApplicationSupportDirectory=/Library/Application Support, -DSystemCachesDirectory=/Library/Caches, -DSystemApplicationDirectory=/Applications, -DSystemUserDirectory=/Users, -DUserHome=${HOME}, -DSandboxEnabled=true, -DLaunchModifierFlags=0, -DLaunchModifierFlagCapsLock=false, -DLaunchModifierFlagShift=false, -DLaunchModifierFlagControl=false, -DLaunchModifierFlagOption=false, -DLaunchModifierFlagCommand=false, -DLaunchModifierFlagNumericPad=false, -DLaunchModifierFlagHelp=false, -DLaunchModifierFlagFunction=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (34908)
+ CommandLine (34977)
+ ImportImagePlugin (35125)
+ ImproveWay (29)
+ Mapillary (1.5.20)
+ MovementAlert (1511141840)
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ ShapeTools (1240)
+ alignways (34977)
+ apache-commons (35092)
+ apache-http (34908)
+ areaselector (359)
+ austriaaddresshelper (57)
+ buildings_tools (35171)
+ changeset-viewer (22)
+ conflation (0.6.4)
+ continuosDownload (82)
+ contourmerge (v0.1.5)
+ ejml (35122)
+ geojson (129)
+ geotools (35169)
+ jaxb (35014)
+ jna (34908)
+ jogl (1.2.3)
+ jts (35122)
+ log4j (34908)
+ opendata (35179)
+ openqa (1557250801)
+ public_transport (34977)
+ reltoolbox (35196)
+ reverter (35084)
+ rex (53)
+ splinex (34908)
+ terracer (34977)
+ todo (30306)
+ turnrestrictions (34977)
+ undelete (34977)
+ utilsplugin2 (35177)
+ wikipedia (1.1.2)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BicycleJunction&preset&zip=1
+ http://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historic_Stone&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Heritage&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/public_bookcase&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Stolpersteine&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Power&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PowerMapping&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/BesideTheRoad_Speed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/TreeCrownDiameter&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&style&zip=1
- https://github.com/simon04/coloured-addresses.mapcss/raw/master/dist/coloured-addresses.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Suburb&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&style&zip=1
- http://maps.openstreetmap.ie/josm/townland.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&style&zip=1
- https://github.com/GlassOceanos/indoor-JOSM-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedCycleNodeNetworks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&zip=1

Validator rules:
+ http://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ http://www.openrailwaymap.org/validator/de-openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
+ https://raw.githubusercontent.com/nlehuby/transport_mapcss/master/transport.validator.mapcss

Last errors/warnings:
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: connect timed out

Attachments (1)

arabic.JPG (202.1 KB) - added by Don-vip 2 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 2 years ago by Stereo

Description: modified (diff)

comment:2 Changed 2 years ago by Don-vip

Keywords: i18n added
Milestone: 19.11
Owner: changed from team to Don-vip
Status: newassigned

We have a few codes not matching our ISO 639-2/3 regex added in #16107/#16687:

name:ko-Latn (137016)
name:ar1 (98369)
name:ja_rm (98098)
name:sr-Latn (33508)
name:zh_pinyin (50276)
name:ja_kana (46640)
name:ja-Latn (39615)
name:ja-Hira (36681)

So we have:

  • -Latn, -Hira for ISO 15924 Latin/Hiragana scripts (Latn, Hira)
  • _kana for ISO 15924 Katakana script (Kana)
  • _rm for rōmaji (romanization of Japanese)
  • _pinyin for Pinyin (romanization of Standard Chinese)
  • ar1 for a variant of Arabic? I can't find what is this code about
Last edited 2 years ago by Don-vip (previous) (diff)

comment:3 Changed 2 years ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15501/josm:

fix #18284 - Add name:ko-Latn|ja_rm|sr-Latn|zh_pinyin|ja_kana|ja-Latn|ja-Hira to the list of known language codes

comment:4 Changed 2 years ago by stoecker

I think you need to add a translators comment for these texts (before the text).

comment:5 Changed 2 years ago by Stereo

I asked a non-mapper friend from Jordan about ar1. He says:

I would say ar is high Arabic and ar1 is a dialect. The pronunciation well change. But the map [from taginfo showing ar1 distribution] contains three dialects: Levant (Syria Lebanon Jordan Palestine), Arabic gulf and even the Iraqi dialect which can be split from the levant.

So we could have ar as Arabic, ar1 as Arabic (dialect)?

comment:6 in reply to:  5 Changed 2 years ago by stoecker

Replying to Stereo:

So we could have ar as Arabic, ar1 as Arabic (dialect)?

It is not JOSM's task to invent new language codes. We should not support non standard codes. Especially not as ar1 does follow any useful convention.

comment:7 Changed 2 years ago by Stereo

This wouldn't be inventing anything, only starting to document a tag that is used about 100k times around the globe. Yeah, we could and should have a better tag, but that's a different process.

comment:8 Changed 2 years ago by Don-vip

I agree with Dirk, we should not in any way promote this exotic tag. There is not a single Arabic dialect but many:
wikipedia:Varieties_of_Arabic#Modern_varieties

ISO 639-3 defines the following codes, people should use them:

Last edited 2 years ago by Don-vip (previous) (diff)

Changed 2 years ago by Don-vip

Attachment: arabic.JPG added

comment:9 Changed 2 years ago by stoecker

In 15506/josm:

see #18284 - I18n comments

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.