Modify

Opened 2 years ago

Closed 2 years ago

#18283 closed enhancement (fixed)

[PATCH] JOSM Remote Control handlers made by third parties should be able to register a preference

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 19.11
Component: Core remotecontrol Version:
Keywords: plugin Cc:

Description

It would be nice for plugins that add a remote control action to be able to show a preference in Remote Control Preferences (to enable/disable it).

Attachments (1)

18283.patch (5.8 KB) - added by taylor.smock 2 years ago.
Don't hardcode PermissionPrefWithDefault values for getPermissionPrefs

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by taylor.smock

Attachment: 18283.patch added

Don't hardcode PermissionPrefWithDefault values for getPermissionPrefs

comment:1 Changed 2 years ago by Don-vip

Milestone: 19.11

comment:2 Changed 2 years ago by Don-vip

Why did you change the order of static initializations? Also, why are the PermissionPrefWithDefault.addPermissionPref in the middle of addRequestHandlerClass calls, and not before or after?

comment:3 Changed 2 years ago by taylor.smock

I changed the order in order to keep the pre-existing order in the Permitted actions: section of the remote control preferences.

The keeping the pre-existing order of actions doesn't matter, then I can change the order to be more readable.

comment:4 Changed 2 years ago by Don-vip

OK I get it. Let's keep the order then.

comment:5 Changed 2 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 15500/josm:

fix #18283 - Remote controle: don't hardcode PermissionPrefWithDefault values for getPermissionPrefs (patch by taylor.smock, modified)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.