IllegalStateException: Missing merge target when using reverter plugin

[austinzhu666@…]

What steps will reproduce the problem?

1. Open JOSM and use reverter plugin
2. Typing the id of changeset and start to download objects
3. At the moment when download is about to finish, crash reported

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-08-26 08:55:27 +0200 (Mon, 26 Aug 2019)
Build-Date:2019-08-26 06:57:10
Revision:15322
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15322 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1903 (18362)
Memory Usage: 785 MB / 1820 MB (623 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 2256x1504
Maximum Screen Size: 2256x1504
Dataset consistency test: No problems found

Plugins:
+ FastDraw (34977)
+ PicLayer (35104)
+ buildings_tools (35171)
+ changeset-viewer (22)
+ ext_tools (34988)
+ pbf (35033)
+ reverter (35084)
+ splinex (34908)
+ undelete (34977)
+ utilsplugin2 (35177)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Handled by bug report queue: java.lang.IllegalStateException: Missing merge target for node 5209470864


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (17) of main
java.lang.IllegalStateException: Missing merge target for node 5209470864
	at reverter.DataSetCommandMerger.getMergeTarget(DataSetCommandMerger.java:64)
	at reverter.DataSetCommandMerger.mergeNode(DataSetCommandMerger.java:83)
	at reverter.DataSetCommandMerger.merge(DataSetCommandMerger.java:179)
	at reverter.DataSetCommandMerger.<init>(DataSetCommandMerger.java:48)
	at reverter.ChangesetReverter.getCommands(ChangesetReverter.java:380)
	at reverter.RevertChangesetTask.revertChangeset(RevertChangesetTask.java:157)
	at reverter.RevertChangesetTask.realRun(RevertChangesetTask.java:89)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:94)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

[GerdP]

If you still can reproduce this, please let us know the changeset id that you try to revert.
In case that you don't revert to a new layer, please safe the content of that layer to a file and attach it to this ticket.

[austinzhu666@…]

It happens generally for all changesets. I will try to have a fresh install and see if the problem gone or not.

[Don-vip]

did you try to revert this changeset? ​https://www.openstreetmap.org/changeset/69075193

[austinzhu666@…]

Issue resolved by fresh install.
Thanks for replying.

[anonymous]

Update: Same issue still reproducible when reverting another changeset: 69072636

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-29 23:59:43 +0200 (Sun, 29 Sep 2019)
Build-Date:2019-09-29 22:01:37
Revision:15390
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15390 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1903 (18362)
Memory Usage: 918 MB / 1820 MB (723 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 2256x1504
Maximum Screen Size: 2256x1504
Dataset consistency test: No problems found

Plugins:
+ FastDraw (34977)
+ PicLayer (35104)
+ buildings_tools (35171)
+ ext_tools (34988)
+ reverter (35084)
+ splinex (34908)
+ utilsplugin2 (35177)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Handled by bug report queue: java.lang.IllegalStateException: Missing merge target for node 5002556312


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (17) of main
java.lang.IllegalStateException: Missing merge target for node 5002556312
	at reverter.DataSetCommandMerger.getMergeTarget(DataSetCommandMerger.java:64)
	at reverter.DataSetCommandMerger.mergeNode(DataSetCommandMerger.java:83)
	at reverter.DataSetCommandMerger.merge(DataSetCommandMerger.java:179)
	at reverter.DataSetCommandMerger.<init>(DataSetCommandMerger.java:48)
	at reverter.ChangesetReverter.getCommands(ChangesetReverter.java:380)
	at reverter.RevertChangesetTask.revertChangeset(RevertChangesetTask.java:157)
	at reverter.RevertChangesetTask.realRun(RevertChangesetTask.java:89)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:94)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

[GerdP]

I cannot reproduce the problem with cs 69072636 using the same JOSM and plugin version when reverting fully to a new layer.
I assume you are reverting to an existing layer, maybe with elements selected?

[austinzhu666@…]

I used the plugin without any existing layer. The error pops out when it says fetching relations(0/2).

[GerdP]

Ah, that was a good hint. You have enabled "Use Overpass server for object downloads" in the connection settings.
This doesn't work with the reverter (and also seems to be much slower).
See #15626

[stoecker]

Maybe revert should check this and warn?

[GerdP]

In #15626 I proposed not to use Overpass for reverter. I still think this would be the best approach.

[stoecker]

Why not do it like described in 15626?

[GerdP]

I tried to implement the suggested fallback without success. See ticket:15626#comment:5 and ticket:15626#comment:6

[stoecker]

Sorry, I referred to comment 5.

[GerdP]

Ah, ok, I hoped for a feedback from Upliner and it slipped my mind. A quick look into the current sources seems to show that this change would still be a good solution.

[GerdP]

I think we can close this ticket as duplicate of #15626?

[austinzhu666@…]

Yes, thank you

[Don-vip]

Closed as duplicate of #15626.