Modify

Opened 9 months ago

Last modified 2 months ago

#18230 new defect

pt_assistent uses error code 3701 which is also used by RightAngleBuildingTest

Reported by: GerdP Owned by: Biswesh
Priority: normal Milestone:
Component: Plugin pt_assistant Version:
Keywords: ignore Cc:

Description

The current implementation to ignore errors expects that the error key is somehow unique. Unfortunately there seems to be no method to verify that and I just found a conflict.
The code 3701 is used by RightAngleBuildingTest and by plugin pt_assistent.
In fact, it seems to be used for two different kinds of errors in pt_assistent:
I see different sources in pt_assisten with code 3701:

./validation/BicycleFootRouteValidatorTest.java:    public static final int ERROR_CODE_CONTINUITY = 3701;
./validation/PTAssistantValidatorTest.java:    public static final int ERROR_CODE_FROM_TO_ROUTE_TAG = 3701;

The plugins directory contains two plugins which use TestError, pt_assistant and wikipedia.
I think pt_assistant uses range 3700..3799, wikipedia seems to reserve 30000..31000, not just
30000..30100.

IIGTR pt_assistant is newer than RightAngleBuildingTest, so it should probably be changed to use a different range.
Maybe we can somehow log a warning when a plugin creates a TestError with a code < 30000?

Attachments (1)

18230-fix-ignore-codes.patch (4.4 KB) - added by GerdP 2 months ago.
patch for plugin

Download all attachments as: .zip

Change History (2)

Changed 2 months ago by GerdP

patch for plugin

comment:1 Changed 2 months ago by GerdP

18230-fix-ignore-codes.patch changes the error codes produced by the plugin pt_assistant to use the range 30700..30799 instead of 3701..3799.
It would be good to be able to fix ignore list entries for the code 3702..3799.
I see only one way to handle this:

  • The modified plugin adds similar ignore list entries in the range 30702 .. 30799 for those with codes 3702..3799
  • The RightAngleBuildingTest is also changed to use a new range, e.g. 4000..4100
  • The code range 3700 .. 3799 must never be used again
  • In one year or so we may remove the entries for 3700..3799
Last edited 2 months ago by GerdP (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Biswesh.
as The resolution will be set.
to The owner will be changed from Biswesh to the specified user.
The owner will change to GerdP
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from Biswesh to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.