Changeset 18637 in josm


Ignore:
Timestamp:
2023-01-17T15:05:33+01:00 (15 months ago)
Author:
taylor.smock
Message:

See #18230: Move RightAngleBuildingTest error code to 4101 from 3701.

This is due to clashing with an error code from pt_assistant.

See also #21423: Ensure validator codes are unique -- replace missed
since xxx with since 18636.

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

    r18636 r18637  
    152152        LongSegment.class, // 3500 .. 3599
    153153        PublicTransportRouteTest.class, // 3600 .. 3699
    154         RightAngleBuildingTest.class, // 3700 .. 3799
     154        // 3700 .. 3799 is automatically removed since it clashed with pt_assistant.
    155155        SharpAngles.class, // 3800 .. 3899
    156156        ConnectivityRelations.class, // 3900 .. 3999
    157157        DirectionNodes.class, // 4000-4099
     158        RightAngleBuildingTest.class, // 4100 .. 4199
    158159    };
    159160

  • trunk/src/org/openstreetmap/josm/data/validation/TestError.java

    r18636 r18637  
    490490     * Get the unique code for this test. Used for ignore lists.
    491491     * @return The unique code (generated with {@code tester.getClass().getName().hashCode() + code}).
    492      * @since xxx
     492     * @since 18636
    493493     */
    494494    public int getUniqueCode() {

  • trunk/src/org/openstreetmap/josm/data/validation/tests/RightAngleBuildingTest.java

    r17405 r18637  
    4444        for (Pair<Double, Node> pair: angles) {
    4545            if (checkAngle(pair.a)) {
    46                 TestError.Builder builder = TestError.builder(this, Severity.OTHER, 3701)
     46                TestError.Builder builder = TestError.builder(this, Severity.OTHER, 4101)
    4747                                                     .message(tr("Building with an almost square angle"))
    4848                                                     .primitives(w)

  • trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerTestIT.java

    r18636 r18637  
    188188            if (org.openstreetmap.josm.data.validation.Test.class.isAssignableFrom(clazz)
    189189            && !Objects.equals(org.openstreetmap.josm.data.validation.Test.class, clazz)) {
    190                 // clazz.getName().hashCode() is how the base error codes are calculated since xxx
     190                // clazz.getName().hashCode() is how the base error codes are calculated since r18636
    191191                // We want to avoid cases where the hashcode is too close, so we want to
    192192                // ensure that there is at least 1m available codes after the hashCode.
Note: See TracChangeset for help on using the changeset viewer.