Modify

Opened 6 years ago

Closed 6 years ago

#18157 closed defect (duplicate)

Conflicting wikipedia tags validation/check

Reported by: slavik.vladimir@… Owned by: floscher
Priority: normal Milestone:
Component: Plugin wikipedia Version: latest
Keywords: template_report wikipedia wikidata Cc:

Description

What steps will reproduce the problem?

  1. Add wikidata=**** and wikipedia=cs:**** to an object.
  2. Try to upload.
  3. Validation shows an error that the value cs:**** is not allowed for wikipedia tags.
  4. Change the tag to wikpiedia:cs=****
  5. Try to upload.
  6. Validation shows a warning that Key wikipedia is not added, but wikipedia:cs is. Make sure to use wikipedia together with wikidata. (paraphrased from localized text)

What is the expected result?

Validation has consistent rules that provide a clear definition of what is wrong and imply how to fix it.

What happens instead?

Validation can not be satisfied either way.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-08-26 08:55:27 +0200 (Mon, 26 Aug 2019)
Build-Date:2019-08-26 06:57:10
Revision:15322
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15322 cs) Windows 7 32-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 849 MB / 989 MB (228 MB allocated, but free)
Java version: 1.8.0_211-b12, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.18)
+ PicLayer (35104)
+ apache-commons (34908)
+ apache-http (34908)
+ buildings_tools (34982)
+ ejml (35049)
+ geotools (34908)
+ imagery_offset_db (34908)
+ jaxb (35014)
+ jna (34908)
+ jts (35064)
+ log4j (34908)
+ measurement (35051)
+ opendata (35102)
+ pointInfo (34908)
+ public_transport (34977)
+ reltoolbox (34977)
+ reverter (35084)
+ utilsplugin2 (35098)
+ wikipedia (v1.1.1)

Map paint styles:
- %UserProfile%\Dropbox\OpenStreetMap\Styles\Styles_NoFeature-style.mapcss

Last errors/warnings:
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
- W: The JSON response from the Wikidata Action API can't be decoded!: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')

Change History (6)

comment:1 by Don-vip, 6 years ago

Component: CoreCore validator
Keywords: wikipedia wikidata added

comment:2 by anonymous, 6 years ago

Component: Core validatorPlugin wikipedia
Owner: changed from team to floscher

I think that this is a Wikipedia plugin issue because AFAIK it provides these validation rules. Maybe the root cause is #18053, also see #17832.

comment:3 by Don-vip, 6 years ago

Summary: Conflicting wikpedia tags validation/checkConflicting wikipedia tags validation/check

comment:4 by slavik.vladimir@…, 6 years ago

Thank you, at a first glance the referenced bugs looks like a good match. #18053 hints at a near release of the plugin (?), so I'll wait for that and re-test.

comment:5 by slavik.vladimir@…, 6 years ago

I have tried again with JOSM r15390 and Wikipedia plugin 1.1.2; I confirm the reported bug is no longer present.

The messages now first tell me that I should not use wikpedia=cs:*, once fixed then that I should use also wikipedia with wikipedia:cs, and finally also that wikpedia and wikidata do not match, if present. Clear and consistent.

Thank you for the fix!

comment:6 by Don-vip, 6 years ago

Resolution: duplicate
Status: newclosed

Closed as duplicate of #18053.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.