Modify

Opened 6 years ago

Closed 6 years ago

#18100 closed defect (fixed)

Seamarks preset wrong values (seamark:type=distance_mark)

Reported by: AdVerburg Owned by: AdVerburg
Priority: normal Milestone:
Component: External preset Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Activate the Seamarks preset, https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
  2. Insert a node in JOSM
  3. Use the seamark preset (B25) to enter tag values,

with "Units for nautical charts:"

What is the expected result? A choice for "kilometres" | "hectometres" | "nautical_miles" | "statute_miles" | "metres" | "feet" as documented in https://wiki.openstreetmap.org/wiki/Seamarks/General_Attributes

What happens instead? A choice for "kilometer" | "hectometer" | "nautical_miles" | "statute_miles" | "meters" | "feet". (American, not British English)

Please provide any additional information below. Attach a screenshot if possible.

Changing the tag values (~ line number 300) in a user defined preset file to the "official" gives the expected behavior.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-08-26 08:55:27 +0200 (Mon, 26 Aug 2019)
Revision:15322
Build-Date:2019-08-26 06:57:10
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15322 en_GB) Linux openSUSE Tumbleweed
Memory Usage: 354 MB / 1970 MB (115 MB allocated, but free)
Java version: 12.0.1+12-suse-1.16-x8664, N/A, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
apache-commons-compress: apache-commons-compress:noarch-1.18
apache-commons-logging: apache-commons-logging:noarch-1.2

Plugins:
+ EasyPresets (1537621333)
+ Mapillary (1.5.18)
+ PicLayer (35104)
+ PolygonCutOut (v0.7)
+ SeaChart (35096)
+ SeaMapEditor (34908)
+ apache-commons (34908)
+ apache-http (34908)
+ ejml (35049)
+ geojson (124)
+ geotools (34908)
+ jaxb (35014)
+ jna (34908)
+ jts (35064)
+ measurement (35051)
+ opendata (35102)
+ reverter (35084)
+ turnrestrictions (34977)
+ utilsplugin2 (35098)

Tagging presets:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Presets_Hafen.xml
+ <josm.pref>/Presets_OpenSeaMap_bridge-preset.xml
+ <josm.pref>/Beacons.xml
+ <josm.pref>/PTstops.xml
+ <josm.pref>/SignalStation.xml
+ <josm.pref>/FerryGroup.xml
+ <josm.pref>/Moorings.xml
+ <josm.pref>/Wreck.xml
+ <josm.pref>/WindTurbine.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1
+ <josm.pref>/INT-1-preset_AD.xml
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml

Map paint styles:
+ https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
+ https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss
- https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT1_MapCSS.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
+ http://duinoord.home.xs4all.nl/OSM/JOSM/NL_traffic_signs/Styles_Traffic_signs-style.mapcss
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Styles/Road_Extended_JOSM_style.zip

Validator rules:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: org.openstreetmap.josm.tools.XmlParsingException: org.xml.sax.SAXParseException; lineNumber: 11; columnNumber: 11; cvc-complex-type.2.4.b: The content of element 'presets' is not complete. One of '{"http://josm.openstreetmap.de/tagging-preset-1.0":chunk, "http://josm.openstreetmap.de/tagging-preset-1.0":group, "http://josm.openstreetmap.de/tagging-preset-1.0":item, "http://josm.openstreetmap.de/tagging-preset-1.0":separator}' is expected. (at line 11, column 11). Cause: org.xml.sax.SAXParseException: cvc-complex-type.2.4.b: The content of element 'presets' is not complete. One of '{"http://josm.openstreetmap.de/tagging-preset-1.0":chunk, "http://josm.openstreetmap.de/tagging-preset-1.0":group, "http://josm.openstreetmap.de/tagging-preset-1.0":item, "http://josm.openstreetmap.de/tagging-preset-1.0":separator}' is expected.
- E: Failed to locate image ''
- W:  Ferry Group: Could not get presets icon 
- E: Failed to locate image ''
- W:  Ferry Group: Could not get presets icon 
- E: Failed to locate image 'images/WindTurbine.svg'
- W: [NODE, CLOSEDWAY] Wind Turbine: Could not get presets icon images/WindTurbine.svg
- E: Failed to locate image 'images/WindTurbine.svg'
- W: [NODE, CLOSEDWAY] Wind Turbine: Could not get presets icon images/WindTurbine.svg

Change History (3)

comment:1 by Don-vip, 6 years ago

Component: CoreExternal preset

comment:2 by Don-vip, 6 years ago

Owner: changed from team to AdVerburg
Status: newneedinfo

Please report the issue to the presets authors: https://github.com/OpenNauticalChart/josm/issues

comment:3 by AdVerburg, 6 years ago

Resolution: fixed
Status: needinfoclosed

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.