Modify

Opened 5 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#18060 closed enhancement (fixed)

throw a warning for nodes with cycleway=crossing

Reported by: francians Owned by: team
Priority: normal Milestone: 19.08
Component: Core validator Version:
Keywords: cycleway crossing node validator Cc:

Description (last modified by Klumbumbus)

What steps will reproduce the problem?

  1. create a node
  2. add tag: cycleway=crossing

What is the expected result?

A warning could be thrown, since according to the spec is not valid:
https://wiki.openstreetmap.org/wiki/Tag:cycleway%3Dcrossing

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

I've talked with local mappers and they agreed to change the node in highway and add bicycle=yes.

I suggest to add this rule to highway.mapcss:

node[cycleway=crossing] {
        throwWarning: tr("wrong crossing tag on a node");
        suggestAlternative: "highway=crossing";
        fixChangeKey: "cycleway => highway";
        fixAdd: "bicycle=yes";
}

Many thanks
Cheers
Francesco

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-07-10 00:52:47 +0200 (Wed, 10 Jul 2019)
Build-Date:2019-07-10 01:30:51
Revision:15238
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15238 it) Linux Antergos Linux
Memory Usage: 1334 MB / 3541 MB (980 MB allocated, but free)
Java version: 1.8.0_181-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35030)
+ buildings_tools (34982)
+ reverter (35084)
+ turnrestrictions (34977)
+ utilsplugin2 (34977)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ ${HOME}/JOSM/MyRules.validator.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (0)

Change History (7)

comment:1 Changed 5 weeks ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 5 weeks ago by Klumbumbus

Same for footway=crossing on nodes, right?

comment:3 in reply to:  2 Changed 5 weeks ago by Klumbumbus

Replying to Klumbumbus:

Same for footway=crossing on nodes, right?

Ah, we already have a warning for this case.

comment:4 Changed 5 weeks ago by Klumbumbus

Milestone: 19.08

comment:5 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15312/josm:

fix #18060 - warn about footway=crossing and cycleway=crossing on nodes

comment:6 Changed 4 weeks ago by Klumbumbus

Some of the wrong objects are used on railway=crossing or highway=traffic_signals, so a manual review by the user is better than an autofix which could worsen the situation.

comment:7 Changed 4 weeks ago by francians

Thanks! The changes LGTM

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.