Opened 6 years ago
Last modified 5 years ago
#18042 new enhancement
complain where wikipedia tag is used instead of correct brand:wikipedia (or wikidata instead of brand:wikidata)
Reported by: | mkoniecz | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | template_report brand wikipedia wikidata | Cc: |
Description
What steps will reproduce the problem?
- Create object with
wikipedia=en:KFC
andwikidata=Q524757
( https://www.wikidata.org/wiki/Q524757 ) - Run validator
What is the expected result?
Validator complain that brand:wikipedia
and brand:wikidata
should be used and offers to replace it (or offers to simply delete such tags)
What happens instead?
Nothing
Please provide any additional information below. Attach a screenshot if possible.
For example see https://www.openstreetmap.org/node/6489549531
wikidata=Q1689380
, wikipedia-en:Jimmy John's
originally used was incorrect, brand:wikidata=Q1689380
, brand:wikipedia-en:Jimmy John's
are preferable in such case
In general any wikidata id from https://github.com/osmlab/name-suggestion-index and any wikipedia page linked to such id can be never correctly used in wikidata
and wikipedia
tag and switching to brand:wikipedia
/brand:wikidata
is always a good edit.
It would be a good idea to have autofix encouraging to swap such tags to ones with brand:
prefixed.
Note that associated wikipedia
also should be moved to brand:wikipedia
I have two implementation ideas
(1) include NSI (+interwiki info) as database inside JOSM - it is more complex, including writing validators rule in Java but allows to use it also for different features (autocompletion of shop on writing name tag like in Vespucci, other validation rules)
(2) generate validation rules from NSI and taginfo data (and also include interwiki info) - main negative here is that it would be necessary to regenerate such rules from time to time
I can write script to generate such datasets and I can write script that will generate validation rules for solution (2) (in fact, I have already written and use very similar script for manual fixing of incorrectly used wikipedia
and wikidata
tags) but I am not sure whatever I can make patch that would add internal database as described in solution (1).
iD ticket (implemented): https://github.com/openstreetmap/iD/issues/6416
URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2019-08-11 22:00:20 +0200 (Sun, 11 Aug 2019) Build-Date:2019-08-12 01:30:56 Revision:15296 Relative:URL: ^/trunk Identification: JOSM/1.5 (15296 en) Linux Ubuntu 16.04.6 LTS Memory Usage: 413 MB / 869 MB (75 MB allocated, but free) Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Screen: :0.0 1920x1080 Maximum Screen Size: 1920x1080 libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1 fonts-noto: fonts-noto:- Dataset consistency test: No problems found Plugins: + OpeningHoursEditor (34977) + PicLayer (35030) + buildings_tools (34982) + continuosDownload (82) + ejml (35049) + geotools (34908) + imagery_offset_db (34908) + jts (35064) + log4j (34908) + measurement (35051) + reverter (35084) + todo (30306) Validator rules: + ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss + ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss + ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss Last errors/warnings: - W: No configuration settings found. Using hardcoded default values for all pools.
Attachments (0)
Change History (2)
comment:1 by , 6 years ago
Keywords: | brand wikipedia wikidata added |
---|
(see also #19664)