[Patch] Creating a multipolygon is wrongly moving highway=* to the relation

[naoliv]

If I am not wrong, I remember that this didn't happen before.

Open the attached file, select all the ways, Ctrl+B to create a multipolygon and see how the highway=residential tag was moved from the ways to the relation.

JOSM:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-08-07 02:39:36 +0200 (Wed, 07 Aug 2019)
Revision:15288
Build-Date:2019-08-07 01:30:53
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15288 pt_BR) Linux Debian GNU/Linux bullseye/sid
Memory Usage: 1139 MB / 2048 MB (268 MB allocated, but free)
Java version: 13-ea+30-Debian-1, Debian, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java ATK Wrapper package: libatk-wrapper-java:all-0.35.0-2
libcommons-compress-java: libcommons-compress-java:all-1.18-2
libcommons-logging-java: libcommons-logging-java:all-1.2-2
VM arguments: [-Dawt.useSystemAAFontSettings=gasp]
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1537621333)
+ FastDraw (34977)
+ OpeningHoursEditor (34977)
+ SimplifyArea (34977)
+ apache-commons (34908)
+ buildings_tools (34982)
+ ejml (35049)
+ geojson (124)
+ geotools (34908)
+ http2 (35062)
+ jaxb (35014)
+ jogl (1.2.3)
+ jts (35064)
+ log4j (34908)
+ measurement (35051)
+ opendata (34997)
+ reverter (34999)
+ tageditor (34977)
+ tagging-preset-tester (34908)
+ todo (30306)
+ turnlanes-tagging (281)
+ turnrestrictions (34977)
+ undelete (34977)
+ utilsplugin2 (34977)
+ wikipedia (v1.1.1)

[GerdP]

Yes, that looks wrong. Do you have an idea about a version that worked differently? I just tried my oldest binary (r9086) and it shows the same problem.

[GerdP]

I just found out that the "Create Multipolygon" button of plugin reltoolbox doesn't show this problem, so maybe you confused them, as I cannot find any hint in the source history of core method CreateMultipolygonAction that it ever worked well in this case unless you add "highway" to this list in advanced preference:

multipoly.lineartagstokeep	[barrier, fence_type, source]

Does that ring a bell?

[naoliv]

Or I am remembering too old stuff (#9623; testing with r7000 it still didn't move highway to the relation) or, coincidentally, this is the first time that I am using all ways with the same highway value since that time.

Maybe there isn't an easy and fast solution that doesn't involve working with the code.

For example, I could include highway in multipoly.lineartagstokeep but when creating a multipolygon from a highway=services|highway=rest_area area, I guess that it would wrongly keep the value in the ways instead moving it to the relation.

[GerdP]

Yes, that was also my thought. I'll have a closer look at the code in reltoolbox. Maybe it is time again to merge it into core.

[GerdP]

Possible solution

[GerdP]

Seems we were both mistaken. The reltoolbox plugin behaves like the core method. I was confused because it selects the new MP while the core method keeps the selection. I also don't find a difference in r7000 (tested with r6999) from the download page. Maybe you tried with added "highway" in multipoly.lineartagstokeep?
So, my only idea so far is to use method ElemStyles.getAreaElemStyle() to test if the copied tags are rendered as an area.
The attached patch implements this and also creates a warning popup.
Problem: The result depends on the active Mappaint style(s).

[skyper]

The patch was never applied and JOSM still does not find the right tags to move. With some highway=* it moved all tags without conflicting value. Additionally, if I cancel the upcoming relation editor the relation is already created where I expected, at least, a dialog to undo the creation or even a silent undo/cancel.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-26 09:33:11 +0200 (Sun, 26 Jul 2020)
Revision:16809
Build-Date:2020-07-27 01:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Not sure how to handle this in general but for highway=* we have strict rules for values allowed on areas. Why not use them?

[skyper]

Oh, and moving only some tags is not acceptable as they all belong together, see #19594, and in my test lanes=* were left as only tag on the ways caused by conflicting values.

#19594 is probably a duplicate but, in my eyes, this is a defect and not a enhancement.