trac xml validation: make at least one revision variable mandatory on wiki Preset/Style/Rule subpages

[Klumbumbus]

On Maps subpages we have a trac integrated xml validation. Can we please have this on Preset/Style/Rule subpages too that they must have [[revision]] or [[date]] (or both)?

I'm tired of adding/restoring the variables.

https://josm.openstreetmap.de/wiki/Presets/BICSpain?action=history

[stoecker]

I'll implement this till/in August. If not, please remember me after mid August before September :-)

[Klumbumbus]

The milestone will remind us

[Klumbumbus]

https://josm.openstreetmap.de/wiki/Presets/Baby_friendliness?action=diff&version=6

[Don-vip]

@valornaram everything is wrong in your last modification. Please reference valid icons and keep the [[revision]]_[[date]] macro.

[stoecker]

Can you please test? Hopefully it has no unwanted side effects ;-)

[Klumbumbus]

Seems to work fine.
Current message: This wiki requires usage of [[revision]]_[[date]] macros instead of hardcoded values
I guess this is confusing for new users. I suggest to add something like:
... in the version variable. More info see wiki page /Presets.

[Klumbumbus]

Replying to stoecker:

unwanted side effects

wiki:Presets can't be edited anymore while wiki:Rules and wiki:Styles work fine

[Klumbumbus]

Also could you generate a list which wiki pages currently don't follow the convention? Checking each page by hand would be a lot work.

[stoecker]

Ok. Checks disabled for the main 3 pages and I fixed the wrong entries (all I hope when my SQL was right :-)

[Klumbumbus]

Thanks.

[valornaram]

I am trying to edit https://josm.openstreetmap.de/wiki/Presets/Baby_friendliness like you said and have the following codeline

<presets xmlns="http://josm.openstreetmap.de/tagging-preset-1.0" author="Discostu36" version="[[revision]]_[[date]]" shortdescription="Baby friendliness" 

but the wiki always fires a warning message claiming that I did not used the macro but I did.

[Don-vip]

What happens if you keep the current form? "1.[[revision]]_[[date]]"

[valornaram]

No it does work. Thank you @Don-vip

[stoecker]

The previous failures had nothing to do with the [[revision]]_[[date]], but you forgot the {{{}}} in one case or stripped the #preset in the later ones. The version="[[revision]]_[[date]]" also works, but would not be consistent with the previous versions (the additional 1 allows to manually issue a major version change, e.g. when the preset changes totally for some reason, but we don't enforce this usage).

There are two buttons below the wiki pages beside sending:

• One allows a preview before submitting
• One shows the differences between current page and your changes graphical.

The second one makes it very easy to spot unwanted changes like the ones you had trouble with.

[Klumbumbus]

So, is this change good? https://josm.openstreetmap.de/wiki/Presets/Baby_friendliness?action=diff&version=8

[Don-vip]

Replying to Klumbumbus:

So, is this change good? https://josm.openstreetmap.de/wiki/Presets/Baby_friendliness?action=diff&version=8

as long as nothing breaks in the next hours, I'd say yes.

[stoecker]

This line is optional, but it's better when it is there as otherwise it falls back to latin1.