Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#17930 closed enhancement (fixed)

trac xml validation: make at least one revision variable mandatory on wiki Preset/Style/Rule subpages

Reported by: Klumbumbus Owned by: stoecker
Priority: normal Milestone: 19.08
Component: Trac Version:
Keywords: Cc: valornaram

Description

On Maps subpages we have a trac integrated xml validation. Can we please have this on Preset/Style/Rule subpages too that they must have [[revision]] or [[date]] (or both)?

I'm tired of adding/restoring the variables.

https://josm.openstreetmap.de/wiki/Presets/BICSpain?action=history

Attachments (0)

Change History (18)

comment:1 Changed 2 years ago by stoecker

I'll implement this till/in August. If not, please remember me after mid August before September :-)

comment:2 Changed 2 years ago by Klumbumbus

Milestone: 19.08

comment:3 Changed 2 years ago by Klumbumbus

The milestone will remind us

comment:5 Changed 2 years ago by Don-vip

Cc: valornaram added

@valornaram everything is wrong in your last modification. Please reference valid icons and keep the [[revision]]_[[date]] macro.

comment:6 Changed 2 years ago by stoecker

Can you please test? Hopefully it has no unwanted side effects ;-)

comment:7 Changed 2 years ago by Klumbumbus

Seems to work fine.
Current message: This wiki requires usage of [[revision]]_[[date]] macros instead of hardcoded values
I guess this is confusing for new users. I suggest to add something like:
... in the version variable. More info see wiki page /Presets.

comment:8 in reply to:  6 Changed 2 years ago by Klumbumbus

Replying to stoecker:

unwanted side effects

wiki:Presets can't be edited anymore while wiki:Rules and wiki:Styles work fine

comment:9 Changed 2 years ago by Klumbumbus

Also could you generate a list which wiki pages currently don't follow the convention? Checking each page by hand would be a lot work.

comment:10 Changed 2 years ago by stoecker

Resolution: fixed
Status: newclosed

Ok. Checks disabled for the main 3 pages and I fixed the wrong entries (all I hope when my SQL was right :-)

comment:11 Changed 2 years ago by Klumbumbus

Thanks.

comment:12 Changed 2 years ago by valornaram

I am trying to edit https://josm.openstreetmap.de/wiki/Presets/Baby_friendliness like you said and have the following codeline

<presets xmlns="http://josm.openstreetmap.de/tagging-preset-1.0" author="Discostu36" version="[[revision]]_[[date]]" shortdescription="Baby friendliness" 

but the wiki always fires a warning message claiming that I did not used the macro but I did.

Last edited 2 years ago by Don-vip (previous) (diff)

comment:13 Changed 2 years ago by Don-vip

What happens if you keep the current form? "1.[[revision]]_[[date]]"

comment:14 Changed 2 years ago by valornaram

No it does work. Thank you @Don-vip

comment:15 Changed 2 years ago by stoecker

The previous failures had nothing to do with the [[revision]]_[[date]], but you forgot the {{{}}} in one case or stripped the #preset in the later ones. The version="[[revision]]_[[date]]" also works, but would not be consistent with the previous versions (the additional 1 allows to manually issue a major version change, e.g. when the preset changes totally for some reason, but we don't enforce this usage).

There are two buttons below the wiki pages beside sending:

  • One allows a preview before submitting
  • One shows the differences between current page and your changes graphical.

The second one makes it very easy to spot unwanted changes like the ones you had trouble with.

comment:17 in reply to:  16 Changed 2 years ago by Don-vip

Replying to Klumbumbus:

So, is this change good? https://josm.openstreetmap.de/wiki/Presets/Baby_friendliness?action=diff&version=8

as long as nothing breaks in the next hours, I'd say yes.

comment:18 Changed 2 years ago by stoecker

This line is optional, but it's better when it is there as otherwise it falls back to latin1.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain stoecker.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.