Modify

Opened 3 years ago

Closed 13 months ago

#17838 closed defect (fixed)

Cmd+Shift+Down selects text on the welcome screen

Reported by: jleedev Owned by: simon04
Priority: normal Milestone: 21.04
Component: Core shortcuts Version:
Keywords: template_report macos download Cc:

Description

What steps will reproduce the problem?

  1. Open JOSM
  2. Press Cmd+Shift+Down

What is the expected result?

"Download data" dialog should open

What happens instead?

Text on the welcome screen is selected

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-06-03 00:05:30 +0200 (Mon, 03 Jun 2019)
Build-Date:2019-06-02 22:10:24
Revision:15155
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15155 en) Mac OS X 10.14.5
OS Build number: Mac OS X 10.14.5 (18F132)
Memory Usage: 209 MB / 1820 MB (87 MB allocated, but free)
Java version: 1.8.0_05-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69680256 1366x768
Maximum Screen Size: 1366x768
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DApplicationDirectory=${HOME}/Applications, -DAutosavedInformationDirectory=${HOME}/Library/Autosave Information, -DDesktopDirectory=${HOME}/Desktop, -DDownloadsDirectory=${HOME}/Downloads, -DMoviesDirectory=${HOME}/Movies, -DMusicDirectory=${HOME}/Music, -DPicturesDirectory=${HOME}/Pictures, -DSharedPublicDirectory=${HOME}/Public, -DSystemLibraryDirectory=/Library, -DSystemApplicationSupportDirectory=/Library/Application Support, -DSystemCachesDirectory=/Library/Caches, -DSystemApplicationDirectory=/Applications, -DSystemUserDirectory=/Users, -DUserHome=${HOME}, -DSandboxEnabled=true, -DLaunchModifierFlags=0, -DLaunchModifierFlagCapsLock=false, -DLaunchModifierFlagShift=false, -DLaunchModifierFlagControl=false, -DLaunchModifierFlagOption=false, -DLaunchModifierFlagCommand=false, -DLaunchModifierFlagNumericPad=false, -DLaunchModifierFlagHelp=false, -DLaunchModifierFlagFunction=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]

Plugins:
+ reverter (34999)
+ utilsplugin2 (34977)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (0)

Change History (8)

comment:1 Changed 3 years ago by Don-vip

Keywords: macos download added

comment:2 Changed 20 months ago by Stereo

Owner: changed from team to jleedev
Status: newneedinfo

Can you try the most recent pre-release at ​https://github.com/thomersch/josm/releases and see if you can still reproduce this? It correctly opens the download dialog for me.

Last edited 20 months ago by Stereo (previous) (diff)

comment:3 Changed 20 months ago by jleedev

Yes, this still occurs in the release 17084, and the pre-release 17200.

To clarify somewhat, if I launch JOSM and don't click anything, the shortcut works correctly. However, if I let JOSM launch in the background and then click on it to switch back to it once it's done loading, then the text becomes selected.

comment:4 Changed 13 months ago by anonymous

This may be fixed. I am testing with a built source, using a3827a13c4e983e97e1b452a4c134ad75bd377ae.

I tried this a few ways.

(1) I launched with "ant run", switched to Firefox, went back to Firefox when josm took focus, waited, switched back to josm by clicking on the Dock icon and then trying the key combo. The Download dialog opened as it should.

(2) I launched with "ant run", switched to Firefox, left josm take the focus, waited until it finished initializing and tried the key combo. The Download dialog opened as it should.

(3) In Finder, I double-clicked on the josm-custom.jar, switched to Firefox, went back to Firefox when josm took focus, waited, switched back to josm by clicking on the Dock icon and then trying the key combo. The Download dialog opened as it should.

I am not sure that I am delighted that the josm splash screen will steal the focus after I explicitly activated another app (Firefox), but that may be a separate issue.

comment:5 Changed 13 months ago by Stereo

I can still reproduce this on the latest tested build and the latest macOS, by just opening JOSM.app. It's unclear to me what causes it to happen or not happen.

Last edited 13 months ago by Stereo (previous) (diff)

comment:6 Changed 13 months ago by simon04

Component: CoreCore shortcuts

comment:7 Changed 13 months ago by simon04

Milestone: 21.04
Owner: changed from jleedev to simon04
Status: needinfoassigned

Related issues: #12224, #19295

comment:8 Changed 13 months ago by simon04

Resolution: fixed
Status: assignedclosed

In 17806/josm:

fix #17838 - Cmd+Shift+Down selects text on the welcome screen

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.