Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12224 closed enhancement (fixed)

[Patch] Dialog for "Search menu items"

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 16.02
Component: Core Version:
Keywords: Cc: strump

Description (last modified by simon04)

I really love the "Search menu items" from #10882. Sometimes the usability is a bit unintuitive (e.g., clicking in the text field already containing a search text does now show the results).

  • I would like to use the dialog from the preset search [F3] for the menu item search
  • I think we can remove preset items from the search results (since they have a separate search)


Attachments (5)

2015-12-23-161925_590x270_scrot.png (12.3 KB) - added by simon04 3 years ago.
12224.patch (35.9 KB) - added by simon04 3 years ago.
help.png (5.4 KB) - added by Don-vip 3 years ago.
12224-v2.patch (36.0 KB) - added by simon04 3 years ago.
Search_menu_items.png (44.4 KB) - added by Klumbumbus 3 years ago.

Download all attachments as: .zip

Change History (23)

Changed 3 years ago by simon04

Changed 3 years ago by simon04

Attachment: 12224.patch added

comment:1 Changed 3 years ago by simon04

Description: modified (diff)

comment:2 Changed 3 years ago by Don-vip

Milestone: 15.1216.01

I fear a lot of trouble on focus management, it was pretty tough to make it work... Let's look at this in next milestone :)

comment:3 Changed 3 years ago by simon04

Focus management? The focus of the text field for the search should be as easy as for the preset search dialog ([F3]).

comment:4 Changed 3 years ago by Don-vip

I didn't look at the patch yet, sorry. I'll try it soon to make smart feedback :)

comment:5 Changed 3 years ago by Don-vip

Milestone: 16.0116.02

Not tested yet sorry, but soon, I promise :)

comment:6 Changed 3 years ago by Don-vip

OK I have tested and I like it :)

comment:7 Changed 3 years ago by Don-vip

a keyboard shortcut should be nice however. Alt-F1 maybe?

comment:8 Changed 3 years ago by simon04

The patch proposes KeyEvent.VK_SPACE, Shortcut.CTRL (inspired by something I do not remember) …

Changed 3 years ago by Don-vip

Attachment: help.png added

comment:9 Changed 3 years ago by Don-vip

OK then. But why is it not displayed?


comment:10 Changed 3 years ago by simon04

I finally found the crucial difference:

  • (a) MainMenu.java vs. (b) -

    a b  
    801801            }
    802802        });
    803803
    804         helpMenu.add(new MenuItemSearchDialog.Action());
     804        add(helpMenu, new MenuItemSearchDialog.Action());
    805805        helpMenu.addSeparator();
    806806        helpMenu.add(statusreport);
    807807        helpMenu.add(reportbug);

Changed 3 years ago by simon04

Attachment: 12224-v2.patch added

comment:11 in reply to:  10 Changed 3 years ago by Don-vip

Replying to simon04:

I finally found the crucial difference:

ah, subtle :D

comment:12 Changed 3 years ago by simon04

Resolution: fixed
Status: newclosed

In 9347/josm:

fix #12224 - Dialog for "Search menu items"

This places the "Search menu items" functionality in the help menu
instead of placing a text field at the very right of the main menu.

Changed 3 years ago by Klumbumbus

Attachment: Search_menu_items.png added

comment:13 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

With long imagery names there is a scrollbar at the bottom and the select and cancel buttons are not in the middle.

When you type something and the long entries disappear, the scrollbar stays. when you try to move it it disappears. After you have done this once and delete your text, the scrollbar is above the buttons, so they are always in the middle. (Then also the scollbar disappears directly when typing something.)

build from jenkins

Build-Date:2016-01-10 13:11:45
Revision:9384
Is-Local-Build:true

Identification: JOSM/1.5 (9384 SVN en) Windows 7 32-Bit
Memory Usage: 194 MB / 247 MB (25 MB allocated, but free)
Java version: 1.8.0_66-b18, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found


Last edited 3 years ago by Klumbumbus (previous) (diff)

comment:14 Changed 3 years ago by simon04

In 9389/josm:

see #12224 - Search menu-items/presets: use vertical scrollbar in list

comment:15 Changed 3 years ago by simon04

In 9390/josm:

see #12224 - Search menu-items/presets: allow to select exacly 1 item

comment:16 Changed 3 years ago by simon04

Resolution: fixed
Status: reopenedclosed

comment:17 Changed 3 years ago by simon04

In 9410/josm:

see #12224 - Search menu items: do not overwrite toolbar action dialogs/search

comment:18 Changed 3 years ago by simon04

In 11031/josm:

see #12224 - Search menu item: make shortcut work when MOTD is focused

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.