Modify

Opened 5 years ago

Closed 5 years ago

#10882 closed enhancement (fixed)

[patch] Implement search box for main menu

Reported by: strump Owned by: team
Priority: major Milestone: 15.02
Component: Core Version: latest
Keywords: menu desktop Cc:

Description

JOSM menu has a lot of items. And sometimes it's hard to find something. Mac OS X allows to search within menu. But it would be nice to have such feature for Windows and Linux too.
I've already implemented this feature.
Screenshot:
https://dl.dropboxusercontent.com/u/16093742/osm/main_menu_search.png

Changed Java class: https://dl.dropboxusercontent.com/u/16093742/osm/MainMenu.java
SVN Patch: https://dl.dropboxusercontent.com/u/16093742/osm/MainMenu.java.patch

Attachments (3)

main_menu_search.png (24.3 KB) - added by strump 5 years ago.
Menu search box screenshot
MainMenu.java (43.7 KB) - added by strump 5 years ago.
Changed source file
MainMenu.java.patch (8.5 KB) - added by strump 5 years ago.
SVN Patch of this feature

Download all attachments as: .zip

Change History (23)

Changed 5 years ago by strump

Attachment: main_menu_search.png added

Menu search box screenshot

comment:1 Changed 5 years ago by strump

Type: defectenhancement

comment:2 Changed 5 years ago by stoecker

Summary: Implement search box for main menu[patch] Implement search box for main menu

comment:3 Changed 5 years ago by stoecker

Some notes regarding patch on first short look: Please add Javadoc and don't use "*" for imports.

Changed 5 years ago by strump

Attachment: MainMenu.java added

Changed source file

Changed 5 years ago by strump

Attachment: MainMenu.java.patch added

SVN Patch of this feature

comment:4 in reply to:  3 Changed 5 years ago by strump

Replying to stoecker:

Some notes regarding patch on first short look: Please add Javadoc and don't use "*" for imports.

Done: added Javadoc comments for methods and classes, changed imports.

comment:5 Changed 5 years ago by Don-vip

Maybe we should also not propose it on OSX if it's already provided by the OS.

comment:6 Changed 5 years ago by Don-vip

comment:7 Changed 5 years ago by Don-vip

Milestone: 15.01

comment:8 in reply to:  6 Changed 5 years ago by strump

Replying to Don-vip:

is it that feature?

Yes. In Mac OS X this search field is also designed to search help topics. Here's screencast on Youtube.

comment:9 Changed 5 years ago by strump

I think it's a good idea to add a placeholder to this search field to explain its purpose. Swing doesn't have built-in placeholders and there are for example: implementation 1, implementation 2.

comment:10 Changed 5 years ago by Don-vip

Milestone: 15.0115.02

move tickets that have not been treated this month to next milestone

comment:11 in reply to:  9 Changed 5 years ago by Don-vip

Replying to strump:

I think it's a good idea to add a placeholder to this search field to explain its purpose. Swing doesn't have built-in placeholders and there are for example: implementation 1, implementation 2.

Good idea (sorry for delay). I already have implemented in JosmTextField.setHint(String) in r7505.

comment:12 Changed 5 years ago by Don-vip

Priority: normalmajor

Now I'm testing it, I find this is really a major UI enhancement !

comment:13 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 8072/josm:

fix #10882 - Implement search box for main menu (modified patch from strump)

comment:14 Changed 5 years ago by aseerel4c26

Resolution: fixed
Status: closedreopened

interesting feature!

However, if you resize the window to about 800 px (in my setup) width (or even smaller) the search box consumes unreasonably much space. The menu entries get truncated whereas the not that important *empty* search box does not. It would be enough if the search box would just show "search" or even less in such low-space situations.

comment:15 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 8075/josm:

fix #10882 - dynamic resize of search box for low resolutions

comment:16 Changed 5 years ago by aseerel4c26

thanks, Don-vip, this works nicely now! I have tested it with 8077.

comment:17 Changed 5 years ago by skyper

Resolution: fixed
Status: closedreopened

At least on my system I suffer focus problems as all my short cuts end up in the text box instead of being interpreted by JOSM. Especially selecting object with any toggle dialog and pressing number key (in my case "3") to zoom does not work anymore. Really annoying, I already thought I have hardware problems before noticing my big string in the search field.

EDT: I use sloppy focus on mouse if this information is needed.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-02-17 02:35:12
Last Changed Author: Klumbumbus
Revision: 8077
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-02-16 23:20:55 +0100 (Mon, 16 Feb 2015)
Last Changed Rev: 8077

Identification: JOSM/1.5 (8077 en) Linux Debian GNU/Linux 7.8 (wheezy)
Memory Usage: 304 MB / 882 MB (62 MB allocated, but free)
Java version: 1.7.0_75, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u75-2.5.4-1~deb7u1
Dataset consistency test: No problems found

Plugins:
- OpeningHoursEditor (30962)
- conflation (0.1.7)
- download_along (30892)
- imagery-xml-bounds (30892)
- imagery_offset_db (30892)
- jts (31002)
- mirrored_download (30962)
- photoadjust (30964)
- reverter (30990)
- terracer (30892)
- todo (29154)
- undelete (30892)
- utilsplugin2 (30993)
- waydownloader (30892)
- wikipedia (30892)
Last edited 5 years ago by skyper (previous) (diff)

comment:18 in reply to:  17 ; Changed 5 years ago by Don-vip

Replying to skyper:

EDT: I use sloppy focus on mouse if this information is needed.

what is this?

comment:19 in reply to:  18 Changed 5 years ago by skyper

Replying to Don-vip:

Replying to skyper:

EDT: I use sloppy focus on mouse if this information is needed.

what is this?

Should probably not be much of interest as we are talking about one window.

A focus mode close to focus on window hovering but trying harder to not loosing the focus e.g. when moving the mouse outside any window. It is an option in dconf/gconf and under Debian available with the gnome-tweak-tools package under "window".

There is a similar problem that you always have to click into map view after selecting in toggle dialogs but I do not find it, right away.

comment:20 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 8081/josm:

fix #10882 - fix focus issues properly

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.