Opened 10 years ago
Closed 10 years ago
#10882 closed enhancement (fixed)
[patch] Implement search box for main menu
Reported by: | strump | Owned by: | team |
---|---|---|---|
Priority: | major | Milestone: | 15.02 |
Component: | Core | Version: | latest |
Keywords: | menu desktop | Cc: |
Description
JOSM menu has a lot of items. And sometimes it's hard to find something. Mac OS X allows to search within menu. But it would be nice to have such feature for Windows and Linux too.
I've already implemented this feature.
Screenshot:
Changed Java class: https://dl.dropboxusercontent.com/u/16093742/osm/MainMenu.java
SVN Patch: https://dl.dropboxusercontent.com/u/16093742/osm/MainMenu.java.patch
Attachments (3)
Change History (23)
by , 10 years ago
Attachment: | main_menu_search.png added |
---|
comment:1 by , 10 years ago
Type: | defect → enhancement |
---|
comment:2 by , 10 years ago
Summary: | Implement search box for main menu → [patch] Implement search box for main menu |
---|
follow-up: 4 comment:3 by , 10 years ago
Some notes regarding patch on first short look: Please add Javadoc and don't use "*" for imports.
comment:4 by , 10 years ago
Replying to stoecker:
Some notes regarding patch on first short look: Please add Javadoc and don't use "*" for imports.
Done: added Javadoc comments for methods and classes, changed imports.
comment:5 by , 10 years ago
Maybe we should also not propose it on OSX if it's already provided by the OS.
comment:7 by , 10 years ago
Milestone: | → 15.01 |
---|
comment:8 by , 10 years ago
Replying to Don-vip:
is it that feature?
Yes. In Mac OS X this search field is also designed to search help topics. Here's screencast on Youtube.
follow-up: 11 comment:9 by , 10 years ago
I think it's a good idea to add a placeholder to this search field to explain its purpose. Swing doesn't have built-in placeholders and there are for example: implementation 1, implementation 2.
comment:10 by , 10 years ago
Milestone: | 15.01 → 15.02 |
---|
move tickets that have not been treated this month to next milestone
comment:11 by , 10 years ago
Replying to strump:
I think it's a good idea to add a placeholder to this search field to explain its purpose. Swing doesn't have built-in placeholders and there are for example: implementation 1, implementation 2.
Good idea (sorry for delay). I already have implemented in JosmTextField.setHint(String)
in r7505.
comment:12 by , 10 years ago
Priority: | normal → major |
---|
Now I'm testing it, I find this is really a major UI enhancement !
comment:14 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
interesting feature!
However, if you resize the window to about 800 px (in my setup) width (or even smaller) the search box consumes unreasonably much space. The menu entries get truncated whereas the not that important *empty* search box does not. It would be enough if the search box would just show "search" or even less in such low-space situations.
follow-up: 18 comment:17 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
At least on my system I suffer focus problems as all my short cuts end up in the text box instead of being interpreted by JOSM. Especially selecting object with any toggle dialog and pressing number key (in my case "3") to zoom does not work anymore. Really annoying, I already thought I have hardware problems before noticing my big string in the search field.
EDT: I use sloppy focus on mouse if this information is needed.
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2015-02-17 02:35:12 Last Changed Author: Klumbumbus Revision: 8077 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Relative URL: ^/trunk URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2015-02-16 23:20:55 +0100 (Mon, 16 Feb 2015) Last Changed Rev: 8077 Identification: JOSM/1.5 (8077 en) Linux Debian GNU/Linux 7.8 (wheezy) Memory Usage: 304 MB / 882 MB (62 MB allocated, but free) Java version: 1.7.0_75, Oracle Corporation, OpenJDK 64-Bit Server VM Java package: openjdk-7-jre:amd64-7u75-2.5.4-1~deb7u1 Dataset consistency test: No problems found Plugins: - OpeningHoursEditor (30962) - conflation (0.1.7) - download_along (30892) - imagery-xml-bounds (30892) - imagery_offset_db (30892) - jts (31002) - mirrored_download (30962) - photoadjust (30964) - reverter (30990) - terracer (30892) - todo (29154) - undelete (30892) - utilsplugin2 (30993) - waydownloader (30892) - wikipedia (30892)
follow-up: 19 comment:18 by , 10 years ago
comment:19 by , 10 years ago
Replying to Don-vip:
Replying to skyper:
EDT: I use sloppy focus on mouse if this information is needed.
what is this?
Should probably not be much of interest as we are talking about one window.
A focus mode close to focus on window hovering but trying harder to not loosing the focus e.g. when moving the mouse outside any window. It is an option in dconf/gconf and under Debian available with the gnome-tweak-tools
package under "window".
There is a similar problem that you always have to click into map view after selecting in toggle dialogs but I do not find it, right away.
Menu search box screenshot