Modify

Opened 18 months ago

Closed 5 months ago

Last modified 5 months ago

#17818 closed enhancement (fixed)

[Patch] Add tower:type=lighting

Reported by: anonymous Owned by: Klumbumbus
Priority: normal Milestone: 20.06
Component: Internal preset Version: latest
Keywords: tower lighting Cc: Klumbumbus

Description

It has its own rendering in osm-carto.
See the wiki https://wiki.openstreetmap.org/wiki/Key:tower:type

Attachments (16)

Communication_tower-14.svg (2.6 KB) - added by skyper 8 months ago.
communications_tower icon to be place under presets/landmark/ from File:Communication_tower-14.svg (PD)
Tower_freestanding.svg (1.1 KB) - added by skyper 8 months ago.
tower:construction=freestanding icon to be place under presets/landmark/ from ​File:Tower_freestanding.svg (PD)
Tower_dome.svg (806 bytes) - added by skyper 8 months ago.
General replacement for [[JOSMImage(...)]] and tower:construction=dome icon to be place under presets/landmark/ from ​​File:Tower_dome.svg (PD)
Tower_lattice.svg (1.1 KB) - added by skyper 8 months ago.
tower:construction=lattice icon to be place under presets/landmark/ from ​​File:Tower_lattice.svg (PD)
Tower_dish.svg (1.9 KB) - added by skyper 8 months ago.
tower:construction=dish icon to be place under presets/landmark/ from ​​File:Tower_dish.svg (PD)
Tower_observation.svg (1.4 KB) - added by skyper 8 months ago.
tower:type=observation/watchtower icon to be place under presets/landmark/ from ​​File:Tower_observation.svg (PD)
Tower_cantilever_communication.svg (1.9 KB) - added by skyper 8 months ago.
tower:type=communication icon to be place under presets/landmark/ from ​​File:Tower_cantilever_communication.svg (PD)
josm_17818_small.patch (59.5 KB) - added by skyper 8 months ago.
smaller patch for preset for #17818 and #16898
josm_17818_bigger.patch (60.5 KB) - added by skyper 8 months ago.
bigger patch for preset for #17818 and #16898
josm_17818_big_com.png (47.1 KB) - added by skyper 8 months ago.
bigger: communication tower
josm_17818_big_tw.png (44.6 KB) - added by skyper 8 months ago.
bigger: tower
josm_17818_sm_com.png (40.0 KB) - added by skyper 8 months ago.
smaller: communications tower
josm_17818_sm_tw.png (42.2 KB) - added by skyper 8 months ago.
smaller: tower
josm_17818_tower_small_v2.patch (3.0 KB) - added by skyper 8 months ago.
tower part small
josm_17818_tower_bigger_v2.patch (4.2 KB) - added by skyper 8 months ago.
tower part bigger
josm_17818_extra.patch (130.4 KB) - added by skyper 8 months ago.
rework of some chunks; lots of missing values_* added to combos

Download all attachments as: .zip

Change History (40)

comment:1 Changed 18 months ago by Klumbumbus

related to #16412 and #10759

comment:2 Changed 18 months ago by Don-vip

Keywords: tower added

comment:3 Changed 8 months ago by skyper

Presets/MastAndTower supports the tag

comment:4 Changed 8 months ago by skyper

Keywords: lighting added
Owner: changed from team to skyper

Changed 8 months ago by skyper

Attachment: Communication_tower-14.svg added

communications_tower icon to be place under presets/landmark/ from File:Communication_tower-14.svg (PD)

Changed 8 months ago by skyper

Attachment: Tower_freestanding.svg added

tower:construction=freestanding icon to be place under presets/landmark/ from ​File:Tower_freestanding.svg (PD)

Changed 8 months ago by skyper

Attachment: Tower_dome.svg added

General replacement for source:trunk/resources/images/presets/landmark/tower.png and tower:construction=dome icon to be place under presets/landmark/ from ​​File:Tower_dome.svg (PD)

Changed 8 months ago by skyper

Attachment: Tower_lattice.svg added

tower:construction=lattice icon to be place under presets/landmark/ from ​​File:Tower_lattice.svg (PD)

Changed 8 months ago by skyper

Attachment: Tower_dish.svg added

tower:construction=dish icon to be place under presets/landmark/ from ​​File:Tower_dish.svg (PD)

Changed 8 months ago by skyper

Attachment: Tower_observation.svg added

tower:type=observation/watchtower icon to be place under presets/landmark/ from ​​File:Tower_observation.svg (PD)

Changed 8 months ago by skyper

tower:type=communication icon to be place under presets/landmark/ from ​​File:Tower_cantilever_communication.svg (PD)

Changed 8 months ago by skyper

Attachment: josm_17818_small.patch added

smaller patch for preset for #17818 and #16898

Changed 8 months ago by skyper

Attachment: josm_17818_bigger.patch added

bigger patch for preset for #17818 and #16898

Changed 8 months ago by skyper

Attachment: josm_17818_big_com.png added

bigger: communication tower

Changed 8 months ago by skyper

Attachment: josm_17818_big_tw.png added

bigger: tower

Changed 8 months ago by skyper

Attachment: josm_17818_sm_com.png added

smaller: communications tower

Changed 8 months ago by skyper

Attachment: josm_17818_sm_tw.png added

smaller: tower

comment:5 Changed 8 months ago by skyper

Owner: changed from skyper to anonymous
Status: newneedinfo
Summary: Add tower:type=lighting[Patch] Add tower:type=lighting

I have attached two versions, a smaller (josm_17818_small.patch) and a bigger one (josm_17818_bigger.patch).

Both add the missing tower:type values lighting and minaret and additional useful tags to man_made=tower, plus add a new preset for man_made=communications_tower (#16898). To use some chunks I did some smaller adjustments to height, ele, material and access. Additionally, I added some values_sort="false" to some tags.

The differences between smaller and bigger are:

  • tower:construction=* missing in smaller
  • no multiselect for tower:type=communication/watchtower in man_made=communications_tower in smaller
  • smaller adds only one new icon communications_tower icon to be place under presets/landmark/ from [osmwiki:File:Communication_tower-14.svg] (PD) and changes one (source:trunk/resources/images/presets/landmark/tower.png to General replacement for [[JOSMImage(presets/landmark/tower)]] and tower:construction=dome icon to be place under presets/landmark/ from ​​[osmwiki:File:Tower_dome.svg] (PD)), while bigger additionally to the two adds five more (tower:construction=dish icon to be place under presets/landmark/ from ​​[osmwiki:File:Tower_dish.svg] (PD), tower:construction=freestanding icon to be place under presets/landmark/ from ​[osmwiki:File:Tower_freestanding.svg] (PD) , tower:construction=lattice icon to be place under presets/landmark/ from ​​[osmwiki:File:Tower_lattice.svg] (PD), tower:type=observation/watchtower icon to be place under presets/landmark/ from ​​[osmwiki:File:Tower_observation.svg] (PD) and tower:type=communication icon to be place under presets/landmark/ from ​​[osmwiki:File:Tower_cantilever_communication.svg] (PD)).

The replacement of source:trunk/resources/images/presets/landmark/tower.png by General replacement for [[JOSMImage(presets/landmark/tower)]] and tower:construction=dome icon to be place under presets/landmark/ from ​​[osmwiki:File:Tower_dome.svg] (PD) is useful as the first does not look nice in preset menu but not needed.
I came not around to copy some code from Presets/MastAndTower and would love to even add icons for tower:type but I did not find nice icons for radar and minaret, so far.

Please, try out and tell me which one you like better.


smaller:

smaller: tower smaller: communications tower


bigger:

bigger: tower bigger: communication tower

comment:6 Changed 8 months ago by skyper

Owner: changed from anonymous to team

comment:7 Changed 8 months ago by skyper

Cc: Klumbumbus added

I could even add technology=* and communication:*=* like communication:radio=* but that might go too far.

What do you think.

comment:8 Changed 8 months ago by Klumbumbus

I think that I'll have a look at the whole tower/mast/communicationtower thing in the next weeks and add internal presets based on your Mast and Tower preset.

comment:9 Changed 8 months ago by skyper

Ok, then I gonna separate my patch after the holidays to turn the not directly related changes into an own patch.

Changed 8 months ago by skyper

tower part small

Changed 8 months ago by skyper

tower part bigger

Changed 8 months ago by skyper

Attachment: josm_17818_extra.patch added

rework of some chunks; lots of missing values_* added to combos

comment:10 Changed 8 months ago by skyper

Ok, josm_17818_extra.patch​ contains rework of <chunks> and lots of missing values_*.
I did not, yet, work through the whole defaultpresets but it is a start and ready to commit.
Some parts are needed for the tower parts below, so, this needes to be committed first/together.
josm_17818_tower_small_v2.patch​ and josm_17818_tower_bigger_v2.patch​ contain the tower specific parts, only.

comment:11 Changed 6 months ago by Klumbumbus

Owner: changed from team to Klumbumbus
Status: needinfoassigned

comment:12 Changed 6 months ago by Klumbumbus

In 16474/josm:

see #17818 - fine tune / unify some presets (based on patch by skyper)

comment:13 Changed 6 months ago by Klumbumbus

I picked out the relevant parts of josm_17818_extra.patch​​. Some remarks:

  • no values_sort="false" if unneeded or for cases without clear order (e.g. voltage, surface, map_type,...), better keep consistent alphabetical order and only disable it in exceptional cases
  • no chunks for simple single tags (e.g. placement, incline, height,...)
  • no unneeded comments for chunks (e.g. <!-- internet -->)
  • no values_i18n="false" for numbers, these are excluded anyway
  • please don't mix different things in such a big patch

comment:14 in reply to:  13 ; Changed 6 months ago by skyper

Replying to Klumbumbus:

I picked out the relevant parts of josm_17818_extra.patch​​. Some remarks:

  • no chunks for simple single tags (e.g. placement, incline, height,...)

Why? If there are many values or a description which needs to be copied and changed in every place a chunk is much easier to handle.

  • please don't mix different things in such a big patch

Yeah, sorry, next time I'll split, right away.

comment:15 in reply to:  14 Changed 6 months ago by Klumbumbus

Replying to skyper:

Replying to Klumbumbus:

I picked out the relevant parts of josm_17818_extra.patch​​. Some remarks:

  • no chunks for simple single tags (e.g. placement, incline, height,...)

Why? If there are many values or a description which needs to be copied and changed in every place a chunk is much easier to handle.

Using chunks all over the place doesn't make the code easier, it just moves the actual code away to another place.

  • please don't mix different things in such a big patch

Yeah, sorry, next time I'll split, right away.

I also meant the josm_17818_extra.patch. It combines changes of values_sort, values_i18n, preset_link, chunks, intendation changes,... which makes the patch hard to understand. Including only one of these in a patch makes it a lot easier and thus will make the patch be applied much faster.

comment:16 Changed 6 months ago by Klumbumbus

Btw, the tower/mast part is still on my todo list...

comment:17 Changed 5 months ago by Klumbumbus

In 16706/josm:

see #10759, see #17818, see #16898 - Add Presets for man_made=mast and man_made=communications_tower, rework preset for man_made=tower, based on patch by skyper, (all icons from https://wiki.openstreetmap.org/, from Geozeisig, all PD and CC0 licensed)

comment:18 Changed 5 months ago by Klumbumbus

some things still todo, see ticket:10759#comment:16

comment:19 Changed 5 months ago by Klumbumbus

Priority: minornormal
Resolution: fixed
Status: assignedclosed

comment:20 Changed 5 months ago by Klumbumbus

Milestone: 20.06

comment:21 Changed 5 months ago by Klumbumbus

In 16707/josm:

see #17818 - typo

comment:22 Changed 5 months ago by Klumbumbus

@skyper: At wiki:/Presets/MastAndTower in "Big communication tower" you use watchtower, but meant observation, right? This is even wrong on https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dcommunications_tower#Useful_combinations

comment:23 in reply to:  22 ; Changed 5 months ago by skyper

Replying to Klumbumbus:

@skyper: At wiki:/Presets/MastAndTower in "Big communication tower" you use watchtower, but meant observation, right? This is even wrong on osmwiki:Tag:man_made=communications_tower#Useful_combinations

You are right, I changed it in the preset which will be outdated in a few weeks anyway. The OSM wiki page still need adjustment.

comment:24 in reply to:  23 Changed 5 months ago by Klumbumbus

Replying to skyper:

The OSM wiki page still need adjustment.

Done.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.