#17695 closed defect (fixed)
Building inside building doesn't find all cases
Reported by: | GerdP | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 19.05 |
Component: | Core validator | Version: | |
Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Have a node inside a closed way, both tagged building=yes
- Make sure nothing is selected, run Validator
- Select the way, run Validator
- Select the node, run Validator
What is the expected result?
Steps 2, 3 and 4 should produce the same warning "Building inside building"
What happens instead?
Only steps 2 and 3 produce the warning
Please provide any additional information below. Attach a screenshot if possible.
The same problem occurs when you add a building=yes node inside a building and upload the changeset: No warning
URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2019-04-28 04:36:41 +0200 (Sun, 28 Apr 2019) Build-Date:2019-04-28 02:37:58 Revision:15031 Relative:URL: ^/trunk Identification: JOSM/1.5 (15031 en) Windows 10 64-Bit OS Build number: Windows 10 Home 1803 (17134) Memory Usage: 591 MB / 1820 MB (356 MB allocated, but free) Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Screen: \Display0 1920x1080 Maximum Screen Size: 1920x1080 VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20190508_115344.jfr] Plugins: + OpeningHoursEditor (34977) + apache-commons (34908) + buildings_tools (34982) + continuosDownload (82) + ejml (34908) + geotools (34908) + jaxb (34908) + jts (34908) + o5m (34908) + opendata (34997) + pbf (34908) + poly (34991) + reverter (34977) + undelete (34977) + utilsplugin2 (34977) Validator rules: + c:\josm\core\data\validator\geometry.mapcss + c:\josm\core\data\validator\wikipedia.mapcss Last errors/warnings: - W: No configuration settings found. Using hardcoded default values for all pools.
Attachments (3)
Change History (11)
by , 6 years ago
Attachment: | 17695.patch added |
---|
comment:1 by , 6 years ago
After uploading the patch I've just recognized that the same problem occurs when a way is inside a way. Will post a 2nd patch.
by , 6 years ago
Attachment: | 17695-v2.patch added |
---|
comment:2 by , 6 years ago
v2 works also with ways, but doesn't solve the problem #14287. So, if you add two or more nodes with building=yes in the same enclosing building only one will be found, in fact the problem gets greater. If you select the two nodes JOSM will produce two warnings, but both for the same node :(
by , 5 years ago
comment:4 by , 5 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Found a few more cases which still don't work. In attached file bib2.osm all 6 groups should produce a warning or error.
Both r15031 and r15067 don't find the errors in the bottom row.
The sample relation R3 doesn't work because we do not yet have code to find a multipolygon inside a polygon or multipolygon.
We have code which seems to support erreneous multipolygon relations where the outer way has the style attribute instead of the relation. This code doesn't work and is thus the reason for the problems in the lower row.
Possible solution