Opened 7 years ago

Last modified 7 years ago

#17691 closed defect

[PATCH] Fix issue where SimilarNamedWay crashes on a subset of names — at Version 1

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 19.05
Component: Core validator Version:
Keywords: Cc:

Description (last modified by taylor.smock)

For some reason, the test crashes when "Milwaukee Brat House" and "Who's On Third" are compared.

In this patch, I've added a regression test to SimilarNamedWaysTests and a to make certain we are within the bounds of the string.

In the test case, the important name for testing is "Who's On Third" -- the other just happened to be a nearby building with a name.

Change History (3)

by taylor.smock, 7 years ago

Attachment: 17691.patch​ added

Add test for a previously known crash and fix the crash

comment:1 by taylor.smock, 7 years ago

Description: modified (diff)

by taylor.smock, 7 years ago

Attachment: 17691_v2.patch​ added

Modify the test case to be clear that one name is unnecessary while the other previously crashed and minimize the crash name to the smallest possible string (Third)

Note: See TracTickets for help on using tickets.