Ticket #17691: 17691_v2.patch

src/org/openstreetmap/josm/data/validation/tests/SimilarNamedWays.java

@@ -244 +244 @@
             String part = "";
             for (int i = 0; i < words.length; i++) {
                 String word = words[i];
-                part = name.substring(start, start + word.length());
+                if (start + word.length() <= name.length()) {
+                    part = name.substring(start, start + word.length());
+                }
                 if (word.equalsIgnoreCase(part)) {
                     break;
                 }

test/unit/org/openstreetmap/josm/data/validation/tests/SimilarNamedWaysTest.java

@@ -129 +129 @@
         checkSimilarity("case only", "Rua Sao Joao", "Rua SAO JOAO", true);
         checkSimilarity("case only", "Rue éèçàïù", "Rue EeCAIU", true);
     }
+
+    /**
+     * Test names that previously caused a crash
+     */
+    @Test
+    public void testSimilarNamesRegression() {
+        assertFalse(test.similaryName("Unnecessary Name", "Third"));
+    }
 }