[PATCH] Fix issue where SimilarNamedWay crashes on a subset of names

[taylor.smock]

For some reason, the test crashes when "Milwaukee Brat House" and "Who's On Third" are compared.

In this patch, I've added a regression test to SimilarNamedWaysTests and a to make certain we are within the bounds of the string.

In the test case, the important name for testing is "Who's On Third" -- the other just happened to be a nearby building with a name.

From IRC:

@skquinn
(opening_hours=* or service_times=* or collection_times=*) in Wisconsin
can someone with JOSM feed this to the Overpass query wizard and see if they get an error when parsing the data returned?
specifically a java.lang.StringIndexOutOfBoundsException: String index out of range: 15
@Richlv
skquinn, failed for me, but did not give a detailed reason in the ui
@skquinn
Richlv: so you got the same error? so this indeed might be a JOSM bug and not my aging laptop acting throwed off again
@simonpoole
maxerickson
^{well it isn't an overpass error
and it works for me
latest josm release
@skquinn
hmm
try validating the data
that's what I think triggered it
@simonpoole
yes that crashes
I would very very much suspecta JOSM bug by the looks of where it borks}

[taylor.smock]

Add test for a previously known crash and fix the crash

[taylor.smock]

Modify the test case to be clear that one name is unnecessary while the other previously crashed and minimize the crash name to the smallest possible string (Third)

[Don-vip]

In 15079/josm:

fix #17691 - fix issue where SimilarNamedWay crashes on a subset of names (patch by taylor.smock)