Opened 7 years ago

Last modified 7 years ago

#17630 closed enhancement

building:part=* and building=* on the same element makes no sense — at Version 1

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.04
Component: Core validator Version:
Keywords: template_report building Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Create closed way
  2. add building:part=yes
  3. add building=yes
  4. Run validator

What is the expected result?

Validator complains, as building part is for part of the building.

Either building=* tag was added incorrectly (as way of mapping for renderer) or this is entire building and building:part is not needed.

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

39k+ affected objects - see https://taginfo.openstreetmap.org/keys/building:part#combinations

inspired by https://github.com/openstreetmap/iD/issues/6204#issuecomment-485016991 comment

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-04-03 00:33:43 +0200 (Wed, 03 Apr 2019)
Build-Date:2019-04-03 01:30:50
Revision:14954
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14954 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 434 MB / 869 MB (83 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ buildings_tools (34904)
+ continuosDownload (82)
+ imagery_offset_db (34867)
+ measurement (34867)
+ reverter (34961)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Change History (1)

comment:1 by mkoniecz, 7 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.