Changes between Version 8 and Version 12 of Ticket #17629


Ignore:
Timestamp:
2019-04-21T10:08:22+02:00 (7 years ago)
Author:
mkoniecz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17629

    • Property Milestone → 19.04
    • Property Resolution → fixed
    • Property Status new → closed

  • Ticket #17629 – Description

    v8 v12  
    1 Patch for the first batch in https://josm.openstreetmap.de/ticket/17629#comment:7
    2 
    3 ==== What steps will reproduce the problem?
    4 1. Create `amenity=restaurant name=Restaurant`
    5 2. Create `amenity=place_of_worship religion=muslim name=Mosque`
    6 2. Create `amenity=toilets name=Toilet`
    7 3. Run validator
    8 
    9 ==== What is the expected result?
    10 Validator complains about descriptive names and offers to remove them
    11 
    12 ==== What happens instead?
    13 Nothing
    14 
    15 
    16 ==== Please provide any additional information below. Attach a screenshot if possible.
    17 http://overpass-turbo.eu/s/I7p http://overpass-turbo.eu/s/I7r http://overpass-turbo.eu/s/I7t
    18 
    19 Next part of https://josm.openstreetmap.de/ticket/17100
    20 
    21 To be added in https://josm.openstreetmap.de/browser/josm/trunk/data/validator/unnecessary.mapcss#L93
    22 
    23 Spotted in https://github.com/osmlab/name-suggestion-index/blob/master/dist/names_discard.json (note that this file list both generic and nonbrand names, not all of the should be purged)
    24 
    25 {{{
    26 URL:https://josm.openstreetmap.de/svn/trunk
    27 Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
    28 Last:Changed Date: 2019-04-03 00:33:43 +0200 (Wed, 03 Apr 2019)
    29 Build-Date:2019-04-03 01:30:50
    30 Revision:14954
    31 Relative:URL: ^/trunk
    32 
    33 Identification: JOSM/1.5 (14954 en) Linux Ubuntu 16.04.6 LTS
    34 Memory Usage: 435 MB / 869 MB (102 MB allocated, but free)
    35 Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
    36 Screen: :0.0 1920x1080
    37 Maximum Screen Size: 1920x1080
    38 Dataset consistency test: No problems found
    39 
    40 Plugins:
    41 + OpeningHoursEditor (34867)
    42 + buildings_tools (34904)
    43 + continuosDownload (82)
    44 + imagery_offset_db (34867)
    45 + measurement (34867)
    46 + reverter (34961)
    47 + todo (30306)
    48 
    49 Validator rules:
    50 + ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
    51 + ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
    52 + ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss
    53 
    54 Last errors/warnings:
    55 - W: java.io.IOException: Attribution is not loaded yet
    56 - W: java.io.IOException: Attribution is not loaded yet
    57 - W: java.io.IOException: Attribution is not loaded yet
    58 - W: java.io.IOException: Attribution is not loaded yet
    59 - W: java.io.IOException: Attribution is not loaded yet
    60 - W: java.io.IOException: Attribution is not loaded yet
    61 - W: java.io.IOException: Attribution is not loaded yet
    62 - W: java.io.IOException: Attribution is not loaded yet
    63 - W: java.io.IOException: Attribution is not loaded yet
    64 - W: java.io.IOException: Attribution is not loaded yet
    65 }}}
     1@Don-vip Are you sure about Rathaus? In Poland removal of name=Ratusz (translates to the same) would be incorrect in many cases, it is often actually a name, even on `building=townhall`.