MarkSeen plugin caused app to become unresponsive for 2-3 minutes

[anonymous]

What steps will reproduce the problem?

What is the expected result?

smooth scrolling and navigation

What happens instead?

frozen screen and unresponsive buttons

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-03-31 21:17:00 +0200 (Sun, 31 Mar 2019)
Build-Date:2019-03-31 20:25:18
Revision:14945
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14945 en) Mac OS X 10.14.3
OS Build number: Mac OS X 10.14.3 (18D109)
Memory Usage: 921 MB / 1820 MB (501 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69934056 2048x1152, Display 188916758 1920x1080
Maximum Screen Size: 2048x1152
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-29b8820f, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-26a1786f.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (34506)
+ apache-http (34632)
+ auto_tools (67)
+ buildings_tools (34904)
+ editgpx (34867)
+ graphview (34867)
+ jaxb (34678)
+ jna (34867)
+ log4j (34527)
+ markseen (12)
+ osm-obj-info (51)
+ routing (34678)
+ tageditor (34867)
+ utilsplugin2 (34932)

Map paint styles:
+ /Volumes/Brazil_Mexico/JOSM Paint Styles and Presets/Kaart Styles 3.1.mapcss
+ /Volumes/Brazil_Mexico/JOSM Paint Styles and Presets/Overlapping Ways.mapcss
+ /Volumes/Brazil_Mexico/JOSM Paint Styles and Presets/Kaart Lane Attributes.mapcss
+ /Volumes/Brazil_Mexico/JOSM Paint Styles and Presets/Kaart Users Dwarf.mapcss

Last errors/warnings:
- E: Handled by bug report queue: java.util.concurrent.RejectedExecutionException: Task org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$MarkBoundsSeenRequest@885020f rejected from org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$QuadTreeEditExecutor@72e40d32[Running, pool size = 1, active threads = 1, queued tasks = 8, completed tasks = 169]
- E: Handled by bug report queue: java.util.concurrent.RejectedExecutionException: Task org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$MarkBoundsSeenRequest@3fa0d35e rejected from org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$QuadTreeEditExecutor@72e40d32[Running, pool size = 1, active threads = 1, queued tasks = 8, completed tasks = 169]
- E: Handled by bug report queue: java.util.concurrent.RejectedExecutionException: Task org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$MarkBoundsSeenRequest@7b0ad50c rejected from org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$QuadTreeEditExecutor@72e40d32[Running, pool size = 1, active threads = 1, queued tasks = 8, completed tasks = 169]
- E: Handled by bug report queue: java.util.concurrent.RejectedExecutionException: Task org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$MarkBoundsSeenRequest@1b527c14 rejected from org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$QuadTreeEditExecutor@72e40d32[Running, pool size = 1, active threads = 1, queued tasks = 8, completed tasks = 169]
- W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- W: Warning - <html>JOSM could not find information about the following plugins:<ul><li>auto_tools</li><li>apache-commons</li><li>tageditor</li><li>graphview</li><li>osm-obj-info</li><li>jaxb</li><li>routing</li><li>editgpx</li><li>utilsplugin2</li><li>markseen</li><li>buildings_tools</li><li>jna</li><li>apache-http</li><li>log4j</li></ul>The plugins are not going to be loaded.</html>


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (39) of javawsApplicationThreadGroup
java.util.concurrent.RejectedExecutionException: Task org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$MarkBoundsSeenRequest@78b9856c rejected from org.openstreetmap.josm.plugins.markseen.QuadTreeMeta$QuadTreeEditExecutor@72e40d32[Running, pool size = 1, active threads = 1, queued tasks = 8, completed tasks = 169]
	at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063)
	at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
	at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379)
	at org.openstreetmap.josm.plugins.markseen.QuadTreeMeta.requestSeenBoundsMark(QuadTreeMeta.java:263)
	at org.openstreetmap.josm.plugins.markseen.QuadTreeMeta.requestSeenBoundsMark(QuadTreeMeta.java:259)
	at org.openstreetmap.josm.plugins.markseen.MarkSeenRoot.zoomChanged(MarkSeenRoot.java:197)
	at org.openstreetmap.josm.gui.NavigatableComponent.lambda$fireZoomChanged$1(NavigatableComponent.java:144)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWait(GuiHelper.java:216)
	at org.openstreetmap.josm.gui.NavigatableComponent.fireZoomChanged(NavigatableComponent.java:142)
	at org.openstreetmap.josm.gui.NavigatableComponent.zoomNoUndoTo(NavigatableComponent.java:703)
	at org.openstreetmap.josm.gui.NavigatableComponent.zoomTo(NavigatableComponent.java:683)
	at org.openstreetmap.josm.gui.NavigatableComponent.zoomTo(NavigatableComponent.java:604)
	at org.openstreetmap.josm.gui.NavigatableComponent.zoomToFactor(NavigatableComponent.java:776)
	at org.openstreetmap.josm.gui.NavigatableComponent.zoomManyTimes(NavigatableComponent.java:768)
	at org.openstreetmap.josm.gui.MapMover.mouseWheelMoved(MapMover.java:256)
	at java.awt.Component.processMouseWheelEvent(Component.java:6627)
	at java.awt.Component.processEvent(Component.java:6311)
	at java.awt.Container.processEvent(Container.java:2239)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2297)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4904)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4564)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4476)
	at java.awt.Container.dispatchEventImpl(Container.java:2283)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84)
	at java.awt.EventQueue$4.run(EventQueue.java:733)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[Don-vip]

Ticket #17550 has been marked as a duplicate of this ticket.

[ris]

Veeeeery interesting - markseen is specifically designed for this not to happen.

I do have one thought about how a locking mechanism I introduced recently could potentially go wrong.

[ris]

I've released v13, which addresses an issue which could _hypothetically_ be the cause of this.

[ris]

Tentatively marking as fixed.