For places tagged as populated places gnis:Class="Populated Place" tag is useless [PATCH]

[mkoniecz]

What steps will reproduce the problem?

1. Create node
2. add gnis:Class=Populated Place + place=hamlet + name=useless imported tag
3. Run validator

What is the expected result?

Validator offers to remove useless tags.

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

All 123k objects with gnis:Class=Populated Place have also place=hamlet ​https://overpass-turbo.eu/s/Hzf and ​https://overpass-turbo.eu/s/Hzh

There are also 1500 objects with natural=peak and gnis:Class=Summit ( ​http://overpass-turbo.eu/s/Hzi )

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-03-31 21:17:00 +0200 (Sun, 31 Mar 2019)
Build-Date:2019-03-31 20:25:18
Revision:14945
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14945 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 213 MB / 869 MB (69 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ buildings_tools (34904)
+ continuosDownload (82)
+ imagery_offset_db (34867)
+ measurement (34867)
+ reverter (34953)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[Don-vip]

In 14953/josm:

fix #17547 - For places and peaks tagged correctly, gnis:Class is useless

[mkoniecz]

On reviewing commit that fixed issue that I reported this I noticed that "All 123k objects with gnis:Class=Populated Place have also place=hamlet" claim that I made is wrong.

Second query was NOT run, and I confused it with "query returned empty set".

I attach patch fixing this issue.

​https://github.com/matkoniecz/josm/commit/d98087dedc6d5f2b780a70c66b59795a38c072d9

​https://github.com/matkoniecz/josm/commit/d98087dedc6d5f2b780a70c66b59795a38c072d9.patch

Sorry for a wrong and misleading comment.

See ​http://overpass-turbo.eu/s/HAi for 11k objects that will be skipped as result of this change.

See also ​http://overpass-turbo.eu/s/HAj for query with list of all often appearing place values.

[Don-vip]

In 14954/josm:

fix #17547 - make test stricter (patch by mkoniecz)

[Don-vip]

In 14963/josm:

see #17547 see #17555 - disable syntax not yet supported