Modify

Opened 15 months ago

Closed 14 months ago

Last modified 12 months ago

#17486 closed enhancement (fixed)

warn about addr:housenumber without number [patch]

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 19.04
Component: Core validator Version:
Keywords: housenumber Cc: ovruni

Description

Finds e.g. addr:housenumber=? or accidently use of addr:housenumber when addr:housename was meant or other typos.

Not sure about use cases outside of the arabic numeral system, however I did not found any at the first 200 pages at taginfo

Also not sure about S/N and s/n. It's an abbreviation for Sem Número or sin número (i.e. without number). However should that really be tagged this way in osm in spanish/portugues speaking countries?

with bbox: https://overpass-turbo.eu/s/H8h
global: https://overpass-turbo.eu/s/H8g (doesn't work for me, overpass out of memory at 2GB)
global relation count: https://overpass-turbo.eu/s/H8j current: 248
global way count: https://overpass-turbo.eu/s/H8m current: 19242
global node count: https://overpass-turbo.eu/s/H8n current: ? (overpass gives no result, maybe too much objects)

*[addr:housenumber][addr:housenumber!~/[0-9]/] {
  throwWarning: tr("{0} without number", "{0.key}");
  assertNoMatch: "way addr:housenumber=0";
  assertNoMatch: "way addr:housenumber=5a";
  assertNoMatch: "way addr:housenumber=5/1";
  assertMatch: "way addr:housenumber=?";
  assertMatch: "way addr:housenumber=unknown";
  assertMatch: "way addr:housenumber=Palace of Westminster";
  assertMatch: "way addr:housenumber=S/N";
}

Attachments (0)

Change History (13)

comment:1 Changed 15 months ago by ovruni

"S/N" and "s/n" (abbreviation of "without number") are often used by some government entities to indicate that they do not have a number. Possibly these values were entered into imports. In my opinion we should not have this value in OpenStreetMap.

There are also "S/N" and "s/n" (abbreviation of "without name") for street names, I have removed some of these values in Peru.

comment:2 Changed 15 months ago by mkoniecz

Also not sure about ​S/N and ​s/n. It's an abbreviation for Sem Número or sin número (i.e. without number). However should that really be tagged this way in osm in spanish/portugues speaking countries?

No. If someone feels that it should be tagged they should use something like name and noname.

comment:3 Changed 14 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14956/josm:

fix #17486 - warn about addr:housenumber without number

comment:4 in reply to:  2 ; Changed 13 months ago by michalfabik

Replying to mkoniecz:

Also not sure about ​S/N and ​s/n. It's an abbreviation for Sem Número or sin número (i.e. without number). However should that really be tagged this way in osm in spanish/portugues speaking countries?

No. If someone feels that it should be tagged they should use something like name and noname.


I'm sorry, did you mean that 'something like name and noname' should be used for a missing _name_? Because ovruni was talking about "S/N" for missing number.

Anyway, there's a similar use case in Ex-Yugoslav countries where "bb" is a an abbreviation of "without number" and it's really common, even in official documents. I wonder if you could somehow suppress the warning for those cases.

comment:5 in reply to:  4 ; Changed 13 months ago by Klumbumbus

Replying to michalfabik:

Anyway, there's a similar use case in Ex-Yugoslav countries where "bb" is a an abbreviation of "without number" and it's really common, even in official documents.

Is there any discussion if addr:housenumber=bb should be used in these countries in osm too?

https://taginfo.openstreetmap.org/tags/addr%3Ahousenumber=bb#map
https://overpass-turbo.eu/s/JkY

Last edited 13 months ago by Klumbumbus (previous) (diff)

comment:6 in reply to:  5 ; Changed 12 months ago by michalfabik

Replying to Klumbumbus:

Is there any discussion if addr:housenumber=bb should be used in these countries in osm too?

https://taginfo.openstreetmap.org/tags/addr%3Ahousenumber=bb#map
https://overpass-turbo.eu/s/JkY

Not that I could find. Upon asking on talk-hr, the Croatian community pointed me to a law that abolishes the 'bb' "house numbers". In Serbia, a similar law is expected to be passed later this year. It's still in use in Bosnia and as for Macedonia and Montenegro, there seem to be no active OSM communities in those countries.

comment:7 in reply to:  6 ; Changed 12 months ago by Klumbumbus

Replying to michalfabik:

Not that I could find. Upon asking on talk-hr, the Croatian community pointed me to a law that abolishes the 'bb' "house numbers". In Serbia, a similar law is expected to be passed later this year. It's still in use in Bosnia and as for Macedonia and Montenegro, there seem to be no active OSM communities in those countries.

Thanks for that research. So...

  • For Croatia and Serbia we should keep the warning.
  • The number of addr:housenumber=bb objects in Macedonia and Montenegro is very low, so we can live with those few possible false positives.
  • I'm going to disable the test in Bosnia.

comment:8 Changed 12 months ago by Klumbumbus

In 15144/josm:

see #17486 - don't warn about addr:housenumber=bb in Bosnia and Herzegovina

comment:9 Changed 12 months ago by Klumbumbus

If anyone has newer information some day regarding official usage of "bb" please let us know :)

comment:10 in reply to:  7 Changed 12 months ago by michalfabik

Replying to Klumbumbus:

  • I'm going to disable the test in Bosnia.


Great, thanks a lot. One more nitpick though, If I may: the spelling "бб" should probably be allowed in the Serb Republic since they primarily use the Cyrillic script for official purposes.

comment:11 Changed 12 months ago by Klumbumbus

There is only one addr:housenumber=бб object in that area: https://overpass-turbo.eu/s/JwQ

comment:12 in reply to:  11 Changed 12 months ago by michalfabik

Replying to Klumbumbus:

There is only one addr:housenumber=бб object in that area: https://overpass-turbo.eu/s/JwQ


Ah, sorry about that, I should have checked. Let's just force Latin script then. Thanks again.

comment:13 Changed 12 months ago by Don-vip

Keywords: housenumber added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.