[Patch] Validator should mark obsolete type=associatedStreet relations

[GerdP]

Relations of type associatedStreet are obsolete when all members are "fully" tagged.
In case of highway that means the highway has a name tag, in case of addresses (buildings)
addr:housenumber and addr:street should exist.
See also ​https://forum.openstreetmap.org/viewtopic.php?id=65510

[GerdP]

The patch implements the check and an auto-fix command to delete the relation.

[GerdP]

I think I should add code to check if the relation has more tags. If e.g. a name:fr tag is found all members should also have the corresponding tag (addr:street:fr or name:fr).
If not, it should not be considered obsolete.

[mkoniecz]

While I support eradication of associatedStreet relations and at least in my region (Poland) there is no support for them to continue existing note that ​https://wiki.openstreetmap.org/wiki/Talk:Relation:associatedStreet#Deprecation_of_associatedStreet_in_Germany asked "Is there a consensus within the German mapper-community"

Maybe it would be worth checking is there support for starting to remove this relations also in other places of the world?

Or is it obviously bad idea and purging it may be started without discussing it (though in that case what was the point of this poll)?

[GerdP]

The relations are used in a way that you cannot remove them, see e.g.
​https://www.openstreetmap.org/relation/8161616
The houses don't have the addr:street tag, you have to evaluate the relation to find it.

[Don-vip]

Relations is a very common way, if not the preferred way, of mapping streets in France.

[GerdP]

@Vincent: What if I reduce the check to relations in Germany?

[Klumbumbus]

After ​https://wiki.openstreetmap.org/wiki/Talk:Relation:associatedStreet#Deprecation_of_associatedStreet_in_Germany has ended and the german wiki page was changed we can add a deprecated warning for all associated streets relations in germany. However thats different from what this ticket is about (removing the relation if addr:street is already on every member).

[Don-vip]

OK if only restricted to Germany.

[GerdP]

With v3 the test is only done in Germany. I've also added code to check if the relation has tags which should appear on the members.
All relation tags starting with addr: should appear on the house members. Others relation tags (except for type, name or source)
stop the processing so that the relation is not marked as obsolete. For example, ref:FR:FANTOIR=* is often used in associatedStreet relations.

[GerdP]

fix some checkstyle / javadoc issues

[GerdP]

Replying to Klumbumbus:

After ​https://wiki.openstreetmap.org/wiki/Talk:Relation:associatedStreet#Deprecation_of_associatedStreet_in_Germany has ended and the german wiki page was changed we can add a deprecated warning for all associated streets relations in germany. However thats different from what this ticket is about (removing the relation if addr:street is already on every member).

Yes, that is very different, but keep it in mind or open a new ticket.
This patch is meant to assist the mappers in Germany which have already started to remove obsolete relations.

[Klumbumbus]

Replying to GerdP:

Yes, that is very different, but keep it in mind or open a new ticket.

--> #17484

[Don-vip]

Replying to GerdP:

stop the processing so that the relation is not marked as obsolete. For example, ref:FR:FANTOIR=* is often used in associatedStreet relations.

Thank you. FANTOIR is a useful tag in France which allows us to follow progress of address mapping.

[GerdP]

In 14906/josm:

fix #17475: Validator should mark obsolete type=associatedStreet relations

[GerdP]

In 14914/josm:

see #17475: Improve test for obsolete associatedStreet relations

• if member is a multipolygon relation try to find location, for other relation types location is not computed
• if location of any member is not computed the relation is not marked obsolete