Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 10 days ago

#17475 closed enhancement (fixed)

[Patch] Validator should mark obsolete type=associatedStreet relations

Reported by: GerdP Owned by: team
Priority: normal Milestone: 19.03
Component: Core validator Version:
Keywords: Cc: Klumbumbus

Description

Relations of type associatedStreet are obsolete when all members are "fully" tagged.
In case of highway that means the highway has a name tag, in case of addresses (buildings)
addr:housenumber and addr:street should exist.
See also https://forum.openstreetmap.org/viewtopic.php?id=65510

Attachments (4)

17475.patch (3.2 KB) - added by GerdP 5 weeks ago.
17475-v2.patch (3.4 KB) - added by GerdP 5 weeks ago.
17475-v3.patch (6.2 KB) - added by GerdP 5 weeks ago.
17475-v4.patch (6.1 KB) - added by GerdP 5 weeks ago.
fix some checkstyle / javadoc issues

Download all attachments as: .zip

Change History (20)

Changed 5 weeks ago by GerdP

Attachment: 17475.patch added

Changed 5 weeks ago by GerdP

Attachment: 17475-v2.patch added

comment:1 Changed 5 weeks ago by GerdP

The patch implements the check and an auto-fix command to delete the relation.

comment:2 Changed 5 weeks ago by GerdP

Cc: Klumbumbus added

comment:3 Changed 5 weeks ago by GerdP

I think I should add code to check if the relation has more tags. If e.g. a name:fr tag is found all members should also have the corresponding tag (addr:street:fr or name:fr).
If not, it should not be considered obsolete.

comment:4 Changed 5 weeks ago by mkoniecz

While I support eradication of associatedStreet relations and at least in my region (Poland) there is no support for them to continue existing note that https://wiki.openstreetmap.org/wiki/Talk:Relation:associatedStreet#Deprecation_of_associatedStreet_in_Germany asked "Is there a consensus within the German mapper-community"

Maybe it would be worth checking is there support for starting to remove this relations also in other places of the world?

Or is it obviously bad idea and purging it may be started without discussing it (though in that case what was the point of this poll)?

Last edited 5 weeks ago by mkoniecz (previous) (diff)

comment:5 Changed 5 weeks ago by GerdP

The relations are used in a way that you cannot remove them, see e.g.
https://www.openstreetmap.org/relation/8161616
The houses don't have the addr:street tag, you have to evaluate the relation to find it.

comment:6 Changed 5 weeks ago by Don-vip

Resolution: wontfix
Status: newclosed

Relations is a very common way, if not the preferred way, of mapping streets in France.

comment:7 Changed 5 weeks ago by GerdP

@Vincent: What if I reduce the check to relations in Germany?

comment:8 in reply to:  6 ; Changed 5 weeks ago by Klumbumbus

After https://wiki.openstreetmap.org/wiki/Talk:Relation:associatedStreet#Deprecation_of_associatedStreet_in_Germany has ended and the german wiki page was changed we can add a deprecated warning for all associated streets relations in germany. However thats different from what this ticket is about (removing the relation if addr:street is already on every member).

comment:9 Changed 5 weeks ago by Don-vip

OK if only restricted to Germany.

Changed 5 weeks ago by GerdP

Attachment: 17475-v3.patch added

comment:10 Changed 5 weeks ago by GerdP

Resolution: wontfix
Status: closedreopened

With v3 the test is only done in Germany. I've also added code to check if the relation has tags which should appear on the members.
All relation tags starting with addr: should appear on the house members. Others relation tags (except for type, name or source)
stop the processing so that the relation is not marked as obsolete. For example, ref:FR:FANTOIR=* is often used in associatedStreet relations.

Changed 5 weeks ago by GerdP

Attachment: 17475-v4.patch added

fix some checkstyle / javadoc issues

comment:11 in reply to:  8 ; Changed 5 weeks ago by GerdP

Replying to Klumbumbus:

After https://wiki.openstreetmap.org/wiki/Talk:Relation:associatedStreet#Deprecation_of_associatedStreet_in_Germany has ended and the german wiki page was changed we can add a deprecated warning for all associated streets relations in germany. However thats different from what this ticket is about (removing the relation if addr:street is already on every member).

Yes, that is very different, but keep it in mind or open a new ticket.
This patch is meant to assist the mappers in Germany which have already started to remove obsolete relations.

comment:12 in reply to:  11 Changed 5 weeks ago by Klumbumbus

Replying to GerdP:

Yes, that is very different, but keep it in mind or open a new ticket.

--> #17484

comment:13 in reply to:  10 Changed 5 weeks ago by Don-vip

Replying to GerdP:

stop the processing so that the relation is not marked as obsolete. For example, ref:FR:FANTOIR=* is often used in associatedStreet relations.

Thank you. FANTOIR is a useful tag in France which allows us to follow progress of address mapping.

comment:14 Changed 5 weeks ago by GerdP

Resolution: fixed
Status: reopenedclosed

In 14906/josm:

fix #17475: Validator should mark obsolete type=associatedStreet relations

comment:15 Changed 5 weeks ago by GerdP

In 14914/josm:

see #17475: Improve test for obsolete associatedStreet relations

  • if member is a multipolygon relation try to find location, for other relation types location is not computed
  • if location of any member is not computed the relation is not marked obsolete

comment:16 Changed 10 days ago by Don-vip

Milestone: 19.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.