Changeset 14914 in josm

Timestamp:

2019-03-21T20:50:24+01:00 (6 years ago)

Author:

GerdP

Message:

see #17475: Improve test for obsolete associatedStreet relations

• if member is a multipolygon relation try to find location, for other relation types location is not computed
• if location of any member is not computed the relation is not marked obsolete

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/Addresses.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/Addresses.java

@@ -430 +430 @@
 
         for (RelationMember m : r.getMembers()) {
-            if (m.getMember().isIncomplete() || m.isRelation() || !isInWarnCountry(m, countryCodes))
+            if (m.getMember().isIncomplete() || !isInWarnCountry(m, countryCodes))
                 return;
 
@@ -475 +475 @@
         } else if (m.isWay()) {
             center = m.getWay().getBBox().getCenter();
+        } else if (m.isRelation() && m.getRelation().isMultipolygon()) {
+            center = m.getRelation().getBBox().getCenter();
         }
         if (center == null)
-            return true;
+            return false;
         for (String country : countryCodes) {
             if (Territories.isIso3166Code(country, center))