Modify ↓

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17443 closed enhancement (fixed)

GPX layer: Download from OSM along this track is slow

Reported by: GerdP Owned by: team
Priority: normal Milestone: 19.03
Component: Core Version:
Keywords: template_report GPX Cc:

Description (last modified by GerdP)

What steps will reproduce the problem?

  1. Load a track with many points, e.g > 100000
  2. Right click on gpx layer and select "Download from OSM along this track"
  3. Select track only and press Download button

What is the expected result?

Quick reaction with Popup asking to confirm download of x areas

What happens instead?

Progress monitor shows slow progress for a while and getting slower and slower

Please provide any additional information below. Attach a screenshot if possible.

Problem is easy to fix, working on a patch.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-03-03 00:16:03 +0100 (Sun, 03 Mar 2019)
Build-Date:2019-03-02 23:16:53
Revision:14824
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14824 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1809 (17763)
Memory Usage: 825 MB / 1820 MB (410 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080

Plugins:
+ apache-commons (34506)
+ austriaaddresshelper (57)
+ buildings_tools (34904)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ measurement (34867)
+ o5m (34867)
+ opendata (34911)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34867)
+ undelete (34883)
+ utilsplugin2 (34915)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: org.openstreetmap.josm.io.IllegalDataException: java.io.IOException: Der Zugriff auf die Clouddatei wurde verweigert. Cause: java.io.IOException: Der Zugriff auf die Clouddatei wurde verweigert
- E: Error - <html>Could not read file '2018-2.kml'.<br>Error is:<br>java.io.IOException: Der Zugriff auf die Clouddatei wurde verweigert</html>

Attachments (0)

Change History (4)

comment:1 by GerdP, 6 years ago

Description: modified (diff)

comment:2 by GerdP, 6 years ago

Resolution: → fixed
Status: new → closed

In 14868/josm:

fix #17443: improve performance for GPX layer action "Download from OSM along this track"

  • use Path2D.append() instead of Area.addToDownload() to calculate the area around the track
  • use only the intersection of the original area in recursive calls of DownloadAlongAction.addToDownload()

Even complex tracks which cover huge areas are now handled within a few seconds insteads of several minutes
Possible improvement: remove progress monitor in DownloadAlongTrackAction and add progress monitor for recursion in addToDownload() in DownloadAlongAction

comment:3 by GerdP, 6 years ago

In 14872/josm:

see #17443: increase threshold value reg. display of progress bar to reflect new calculation speed
With normal sized gpx tracks the calculation is done in a few miliseconds

comment:4 by GerdP, 6 years ago

Milestone: → 19.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.