Modify

Opened 6 years ago

Last modified 4 years ago

#17442 new enhancement

[Patch] Avoid to show conflict dialog with Replace Geometry

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Plugin utilsplugin2 Version:
Keywords: template_report replace geometry conflict parent relation Cc:

Description

What steps will reproduce the problem?

  1. Open attached file
  2. Search for type:way new | id:50896755 to select two ways with identical end points and direction
  3. Use Replace Geometry

What is the expected result?

Nodes of existing way are replaced by those of the new way

What happens instead?

A popup dialog is shown which claims that I combine ways and I have to select Keep for each relation.
The texts in the dialog don't really reflect the intended Action.

Please provide any additional information below. Attach a screenshot if possible.

I see no need to show this dialog.
See also https://forum.openstreetmap.org/viewtopic.php?id=65590

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-03-03 00:16:03 +0100 (Sun, 03 Mar 2019)
Build-Date:2019-03-02 23:16:53
Revision:14824
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14824 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 587 MB / 1820 MB (451 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20190310_094925.jfr]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34904)
+ continuosDownload (82)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34867)
+ opendata (34911)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34867)
+ undelete (34883)
+ utilsplugin2 (34915)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [TMS_BLOCK_v2] Resetting cache

Attachments (2)

sample.osm.bz (58.0 KB ) - added by GerdP 6 years ago.
17422.patch (1.6 KB ) - added by GerdP 6 years ago.
Possible solution?

Download all attachments as: .zip

Change History (6)

by GerdP, 6 years ago

Attachment: sample.osm.bz added

by GerdP, 6 years ago

Attachment: 17422.patch added

Possible solution?

comment:1 by GerdP, 6 years ago

Component: CorePlugin utilsplugin2
Summary: Avoid to show conflict dialog with Replace Geometry[Patch] Avoid to show conflict dialog with Replace Geometry

comment:2 by Don-vip, 6 years ago

This doesn't feel the good place to add this logic. I'm sure there are other cases where we could skip the conflict, and we won't list all of them here. Better find something generic that can be called from utilsplugin2 ReplaceGeometry action.

comment:3 by GerdP, 6 years ago

I was also not very happy with the patch. Do you have an example for another situation where we could skip the conflict?

comment:4 by skyper, 4 years ago

Keywords: replace geometry conflict parent relation added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to GerdP.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.