Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#17377 closed enhancement (fixed)

Complain about shop=yes

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.02
Component: Core validator Version:
Keywords: template_report shop Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Create node
  2. Add shop=yes
  3. Run validator

What is the expected result?

Validator complains and requests replacement by more specific tag

What happens instead?

Validator does not complain

Please provide any additional information below. Attach a screenshot if possible.

shop=* is causing complaints
tagging shop=yes on amenity fuel is quite popular and is not blatantly incorrect

Equivalent issue in iD: https://github.com/openstreetmap/iD/issues/5955

Related issue in default map style: https://github.com/gravitystorm/openstreetmap-carto/issues/3697

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-02-23 17:46:51 +0100 (Sat, 23 Feb 2019)
Build-Date:2019-02-24 02:30:49
Revision:14802
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14802 en) Linux Ubuntu 16.04.5 LTS
Memory Usage: 394 MB / 869 MB (102 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ buildings_tools (34867)
+ continuosDownload (82)
+ imagery_offset_db (34867)
+ measurement (34867)
+ reverter (34867)
+ todo (30306)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- W: couldn't parse wizard input
- E: org.openstreetmap.josm.tools.UncheckedParseException
- W: java.net.SocketTimeoutException: connect timed out
- E: java.net.SocketTimeoutException: connect timed out
- W: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketTimeoutException: connect timed out

Attachments (0)

Change History (5)

comment:1 Changed 3 months ago by mkoniecz

It should be added at https://josm.openstreetmap.de/browser/josm/trunk/data/validator/deprecated.mapcss#L454

If that would be useful I can make patch based using a git mirror

Last edited 3 months ago by mkoniecz (previous) (diff)

comment:2 Changed 3 months ago by mkoniecz

Description: modified (diff)

comment:3 Changed 3 months ago by Don-vip

Keywords: shop added
Milestone: 19.02

comment:4 Changed 3 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14805/josm:

fix #17377 - complain about shop=yes, except for amenity=fuel

comment:5 Changed 3 months ago by mkoniecz

Thank you very much, hopefully usage will peak today at 149 222 usages (9 477 are not so terrible uses at amenity=fuel).

Or maybe tomorrow.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.