[Patch] Show last used tags in Add Tag Dialog

[GerdP]

What steps will reproduce the problem?

1. Create new data layer, add a node and press Alt+A to add a tag
2. Add e.g. barrier=bollard and press Enter
3. Press Alt+S to edit the tag value and change bollard to block
4. Add a new node and press Alt+A

What is the expected result?

The dialog should show barrier=block as first entry

What happens instead?

barrier=bollard is top

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2019-02-14 11:29:59
Revision:14786
Is-Local-Build:true

Identification: JOSM/1.5 (14786 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 614 MB / 1753 MB (254 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:51784, -ea, -Dfile.encoding=UTF-8]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34867)
+ continuosDownload (82)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34867)
+ opendata (34867)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34867)
+ undelete (34883)
+ utilsplugin2 (34867)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[GerdP]

The patch just changes the behaviour. Maybe the dialog should also be changed to show "Recently used tags" instead of "Recently added tags"?

[GerdP]

If I hear no complains I'll commit the patch as is on Sunday.

[Hb---]

Please additionally change some translatable strings in this file

@@ -687,5 +687,5 @@
         protected AddTagsDialog() {
-            super(Main.parent, tr("Add value?"), tr("OK"), tr("Cancel"));
+            super(Main.parent, tr("Add Tag"), tr("OK"), tr("Cancel"));
             setButtonIcons("ok", "cancel");
             setCancelButton(2);
             configureContextsensitiveHelp("/Dialog/AddValue", true /* show help button */);
@@ -712,5 +712,5 @@
 
-            mainPanel.add(new JLabel(tr("Please select a value")), GBC.eol());
+            mainPanel.add(new JLabel(tr("Choose a value")), GBC.eol());
             values.setEditable(true);
             mainPanel.add(values, GBC.eop().fill(GBC.HORIZONTAL));

This will reduce the workload for translators because all new strings are already in use in JOSM:

"Add Tag" in source:/josm/trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java#L1089​

"Choose a value" in source:/josm/trunk/src/org/openstreetmap/josm/gui/conflict/tags/MultiValueCellEditor.java#L224​

[GerdP]

Sorry for the delay. I'll commit v2 after release of 19.2.

[GerdP]

In 14926/josm:

fix #17333: Show last used tags in Add Tag Dialog

[GerdP]

In 14928/josm:

see #17333: remove "?" from title so that already existing I18N string can be used.

[Klumbumbus]

This is a pretty major change (it is possibly the most used dialog in JOSM). That will be on the startup page of next release.

[GerdP]

I see it more as a bug fix ;)
I don't see a need documment this change in the Wiki, I think it already describes what is now implemented.
Oops, of course the screen shot is outaged now.

[Don-vip]

Replying to Klumbumbus:

That will be on the startup page of next release.

This is a very minor change, not fit to be listed there.

EDIT: Sorry, I thought you were speaking about the removal of the ? character!