Modify

Opened 2 months ago

Last modified 2 months ago

#17324 new defect

Adding bridge preset to highways not working

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

Steps to reproduce:

  1. Select a highway (eg. residential)
  2. Search for bridge in presets
  3. Apply bridge preset to the selected way
  4. Nothing happens

Attachments (0)

Change History (7)

comment:1 Changed 2 months ago by anonymous

Although it's working if you add the bridge preset to an untagged way.

comment:2 Changed 2 months ago by GerdP

With an untagged way the presets defaults to bridge=yes while with a tagged way you have to select what kind of bridge it is.
No idea if that is intended.

comment:3 in reply to:  2 Changed 2 months ago by anonymous

Replying to GerdP:

No idea if that is intended.

Yeah, maybe intended but it's confusing.

comment:4 Changed 2 months ago by anonymous

Replying to GerdP:

[...] with a tagged way you have to select what kind of bridge it is.

I see two possible solutions:

  1. solution: Gray out the apply button until something is changed in the preset editor (or whatever it called)
  2. solution: Use the same defaults (bridge=yes and layer=1) as with untagged ways or at least bridge=yes.

comment:5 Changed 2 months ago by GerdP

I've now learned that the behaviour depends on a preference setting:
taggingpreset.fill-default-for-tagged-primitives
This is false by default. In Expertmode you can change it to true to get what you want.

comment:6 Changed 2 months ago by Klumbumbus

The current behavior (ignoring defaults) is intended as users maybe do not expect that opening a preset from the Tags/Membership panel, changing nothing themself and closing with the apply preset button changes the object by adding tags. I can't find the ticket where Dirk explained that to me when I was confused about this ;)

comment:7 in reply to:  6 Changed 2 months ago by anonymous

Replying to GerdP:

I've now learned that the behaviour depends on a preference setting:
taggingpreset.fill-default-for-tagged-primitives
This is false by default. In Expertmode you can change it to true to get what you want.

Thanks, it's working. But I don't want to be selfish. It would be great if all JOSM users would know about this flag (or fixed the issue :)

Replying to Klumbumbus:

The current behavior (ignoring defaults) is intended as users maybe do not expect that opening a preset from the Tags/Membership panel, changing nothing themself and closing with the apply preset button changes the object by adding tags. I can't find the ticket where Dirk explained that to me when I was confused about this ;)

Oh okay, this way it makes sense. Please, not forget that the presets can bring forth by searching (default shortcut is F3). This way it's not acceptable, that apply button does nothing. Also, I think by searching most people would like to add new tags, not modifying them.

The scenario you described above can be easily solved by:

  1. Greying out the apply button until something is changed in the preset editor AND/OR
  2. Checking where that preset editor activity called from. If from Tags/Membership panel -> disable defaults, else no change (enable).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to anonymous
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.