Opened 6 years ago
Closed 6 years ago
#17323 closed enhancement (fixed)
[Patch] Duplicate tooltip "Show preset search dialog"
Reported by: | Hb--- | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 19.02 |
Component: | Core | Version: | |
Keywords: | English l18n | Cc: |
Description (last modified by )
The items Search preset… and Search for objects by preset… in the Presets menu have the same string as tooltip. This confuses translators and users.
While "Show preset search dialog" is fine for the Search preset… item[1], the Search for objects by preset… item[2] should get the new string "Search for objects by their presets." as tooltip.
The patch is attached.
[1]
source:/josm/trunk/src/org/openstreetmap/josm/actions/TaggingPresetSearchAction.java#L24
[2]
source:josm/trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSearchPrimitiveDialog.java#L35
-
C:/Users/hb/Desktop/
old new 32 32 * Constructs a new {@link TaggingPresetSearchPrimitiveDialog.Action}. 33 33 */ 34 34 public Action() { 35 super(tr("Search for objects by preset..."), "dialogs/search", tr("S how preset search dialog"),35 super(tr("Search for objects by preset..."), "dialogs/search", tr("Search for objects by their presets."), 36 36 Shortcut.registerShortcut("preset:search-objects", tr("Search for objects by preset"), KeyEvent.VK_F3, Shortcut.SHIFT), 37 37 false); 38 38 putValue("toolbar", "presets/search-objects");
Attachments (1)
Change History (3)
by , 6 years ago
Attachment: | patchNewTooltip-SearchForObjByPreset added |
---|
comment:1 by , 6 years ago
Description: | modified (diff) |
---|---|
Milestone: | → 19.02 |
Summary: | Duplicate tooltip "Show preset search dialog" → [Patch] Duplicate tooltip "Show preset search dialog" |
comment:2 by , 6 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
In 14786/josm: