Modify

Opened 3 months ago

Closed 3 months ago

#17323 closed enhancement (fixed)

[Patch] Duplicate tooltip "Show preset search dialog"

Reported by: Hb--- Owned by: team
Priority: minor Milestone: 19.02
Component: Core Version:
Keywords: English l18n Cc:

Description (last modified by Don-vip)

The items Search preset… and Search for objects by preset… in the Presets menu have the same string as tooltip. This confuses translators and users.

While "Show preset search dialog" is fine for the Search preset… item[1], the Search for objects by preset… item[2] should get the new string "Search for objects by their presets." as tooltip.

The patch is attached.

[1]
source:/josm/trunk/src/org/openstreetmap/josm/actions/TaggingPresetSearchAction.java#L24

[2]
source:josm/trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSearchPrimitiveDialog.java#L35

  • C:/Users/hb/Desktop/

    old new  
    3232         * Constructs a new {@link TaggingPresetSearchPrimitiveDialog.Action}.
    3333         */
    3434        public Action() {
    35             super(tr("Search for objects by preset..."), "dialogs/search", tr("Show preset search dialog"),
     35            super(tr("Search for objects by preset..."), "dialogs/search", tr("Search for objects by their presets."),
    3636                    Shortcut.registerShortcut("preset:search-objects", tr("Search for objects by preset"), KeyEvent.VK_F3, Shortcut.SHIFT),
    3737                    false);
    3838            putValue("toolbar", "presets/search-objects");

Attachments (1)

patchNewTooltip-SearchForObjByPreset (797 bytes) - added by Hb--- 3 months ago.

Download all attachments as: .zip

Change History (3)

Changed 3 months ago by Hb---

comment:1 Changed 3 months ago by Don-vip

Description: modified (diff)
Milestone: 19.02
Summary: Duplicate tooltip "Show preset search dialog"[Patch] Duplicate tooltip "Show preset search dialog"

comment:2 Changed 3 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14786/josm:

fix #17323 - better tooltip for "Show preset search dialog" (patch by Hb---)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.