Modify

Opened 11 days ago

Closed 11 days ago

Last modified 10 days ago

#17302 closed enhancement (fixed)

Long delay when validator shows "Updating ignored errors"

Reported by: GerdP Owned by: team
Priority: normal Milestone: 19.02
Component: Core Version:
Keywords: performance Cc: simon04

Description

When you run the validator with "information level" enabled (other) it is likely to get thousands of entries. These entries are sorted using TestError.compare() which is quite costly.
On my machine it requires more than 3 seconds to sort a list of ~8850 errors like this.

Attachments (1)

17302.patch (1.3 KB) - added by GerdP 10 days ago.
possible code simplification

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 days ago by GerdP

Resolution: fixed
Status: newclosed

In 14768/josm:

fix #17302: reduce sort time in ValidatorTreePanel.buildTree()

comment:2 Changed 11 days ago by GerdP

Please review: TestError still implements Comparable<TestError> although this should no longer be needed. I did not dare to remove it because we have some plugins which use the class TestError. Will have a look later.

Changed 10 days ago by GerdP

Attachment: 17302.patch added

possible code simplification

comment:3 Changed 10 days ago by GerdP

Cc: simon04 added

I found that only the plugins pt_assistent and wikipedia refer to class TestError. I was able to compile both plugins with the attached patch. Can I simply commit it or is it better to keep the legacy code?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.