[Patch] TagChecker.isTagInPresets() doesn't work

[GerdP]

Javadoc says that it returns true "if the given tag is in internal presets"
In fact it returns true if the given tag key is in the presets.

The patched version causes unit test TaginfoTestIT.testCheckPopularTags() to fail as it now finds some values which are not in the presets.

[stoecker]

Hmm, shouldn't probably that values.isEmpty() be an value.isEmpty()?

[GerdP]

Yes, would be an alternative. Anyway, the code requires more changes when this fixed, else we'll see thousands of new errors.
Working on it...

[Don-vip]

I don't think the patch is correct. What happens when calling the method with name=foobar?

[GerdP]

The patched method returns false, which is correct IMHO.

[GerdP]

My understanding is this: We have presets where we have a list of values, and we have presets where we only have a key.
So, isTagInPresets(String key, String value) should only return true if the combination of both is in the presets, while
isKeyInPresets(String key) should return true even if no values are present.

[GerdP]

v2 of the patch works with the existing unit tests and produces the same results in JOSM validator. If I hear no complains I'll commit it this evening.

[GerdP]

In 14704/josm:

fix #17219 TagChecker.isTagInPresets() doesn't work