Modify

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#17199 closed defect (fixed)

Validator complains about "width" tags

Reported by: mueschel Owned by: team
Priority: normal Milestone: 19.01
Component: Core validator Version: tested
Keywords: Cc: GerdP

Description

I recently (currently using 14620) see many warnings about the value of 'width' like

Value '12.8' for key 'width' looks like one of [1.5, 2.5]. (1)
Wert '4.3' für Schlüssel 'width' sieht aus wie '4.5'. (1)

These values are perfectly fine and the validator should not complain about any numeric value for keys like 'width', 'height', 'length'... The only exception might be values with more decimals than reasonably possible (e.g. 2.23473189031) like they happen when importing float values.

Attachments (0)

Change History (10)

comment:1 Changed 2 months ago by simon04

Cc: GerdP added
Milestone: 19.01
Type: enhancementdefect

Related to the changes from #17055.

comment:2 Changed 2 months ago by GerdP

Hmm, seems that there is an external preset with those values as default. It doesn't happen with the default presets.
I guess I have to add these tags to an exclude list.

comment:3 Changed 2 months ago by GerdP

Resolution: fixed
Status: newclosed

In 14683/josm:

fix #17199 Add keys length and width to ignore list

comment:4 Changed 2 months ago by mueschel

It looks like this is a more general problem, not limited to width and length. Some Examples:

Wert '1985' für Schlüssel 'start_date' sieht aus wie '1895'. (4)

-> I'm not aware 1895 was a particularly interesting year.

Wert 'К-150' für Schlüssel 'fire_hydrant:diameter' sieht aus wie '150'.

-> K-150 is a very common value used in Russia

comment:5 Changed 2 months ago by GerdP

Yes, I want to change the code to read common values from a list provided by taginfo.
In the meantime I might change the code to ignore vales when preset values are all numerical.

BTW: I'd like to know where this value 1895 comes from. It is not in the default presets.

comment:6 Changed 2 months ago by mueschel

1895 is one of the examples in the "Historical Objects" preset.
https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects

Tagging presets:
+ http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/current/roofspresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1
+ http://www.country-linedance.de/daten/Verkehrszeichen-vorlage.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/hiking_routes_with_trail_marking&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewParkingFeatures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1

comment:7 Changed 2 months ago by GerdP

OK, thanks, I already wondered if there is an error in the program logic that extracts the default values...

comment:8 Changed 2 months ago by GerdP

Resolution: fixed
Status: closedreopened

comment:9 Changed 2 months ago by GerdP

Resolution: fixed
Status: reopenedclosed

In 14696/josm:

fix #17199
  • Don't suggest different spelling when all preset values for a key are numerical
  • Add layer to ignore list, is checked in MapCSSTagChecker
  • Add start_date end end_date to ignore list
  • apply modified version of 17055-use-ignore.patch:
    • the lines from ignoretags.cfg starting with K: are treated as "often used".
    • instead of "... is not in the presets ..." use "... is unknown ..." in messages
Last edited 2 months ago by GerdP (previous) (diff)

comment:10 Changed 2 months ago by GerdP

Reg. fire_hydrant:diameter=K-150:
This is a bit special. The default presets say that the value should specify the "Diameter (mm)".
The wiki says: "# (numeric value) in mm, inches or letters. ".
Taginfo shows more values starting with K-
I assume that firefighters know what it means?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.