Modify

Opened 5 years ago

Last modified 5 months ago

#17172 new enhancement

[WIP PATCH] turn:lanes and lanes should match

Reported by: taylor.smock Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: mapcss lanes lanes-tagging Cc:

Description

We should ensure that lanes equals turn:lanes when turn:lanes exists. This also applies to the forward and backward variants.

Attachments (1)

turn_lanes.patch (2.5 KB ) - added by taylor.smock 5 years ago.
mapcss checks for bad data

Download all attachments as: .zip

Change History (6)

by taylor.smock, 5 years ago

Attachment: turn_lanes.patch added

mapcss checks for bad data

comment:1 by skyper, 4 years ago

Keywords: lanes lanes-tagging added

Be careful, there could be more turn:lanes than lanes if there is a bicycle lane.

True is that the number of turn:lanes should be equal or higher than lanes but that is true for all *:lanes-tags

Last edited 4 years ago by skyper (previous) (diff)

comment:2 by taylor.smock, 4 years ago

The other thing to consider is that, pursuant the lanes specification, half-lanes are not counted. I'll have to rework this patch sometime for that.

comment:3 by simon04, 4 years ago

Summary: [PATCH] turn:lanes and lanes should match[WIP PATCH] turn:lanes and lanes should match

in reply to:  1 ; comment:4 by 1ec5, 5 months ago

Replying to skyper:

Be careful, there could be more turn:lanes than lanes if there is a bicycle lane.

True is that the number of turn:lanes should be equal or higher than lanes but that is true for all *:lanes-tags

Apparently the strict equality check found its way into JOSM at some point via a different patch, but I’m not sure when: #21725.

in reply to:  4 comment:5 by skyper, 5 months ago

Replying to 1ec5:

Replying to skyper:

Be careful, there could be more turn:lanes than lanes if there is a bicycle lane.

True is that the number of turn:lanes should be equal or higher than lanes but that is true for all *:lanes-tags

Apparently the strict equality check found its way into JOSM at some point via a different patch, but I’m not sure when: #21725.

No, JOSM core is correct but the plugin turnlanes-tagging is damaging data.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to taylor.smock.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.