Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#17149 closed defect (fixed)

Preset for hydrant breaks with conventions

Reported by: SimonPoole Owned by: team
Priority: normal Milestone: 18.12
Component: Internal preset Version:
Keywords: Cc: Klumbumbus


The "new" hydrant preset item uses capitalized values for couplings:type instead of all lower case, which has in general been the convention for values that are not object names or similar (there are some other problematic aspects of the preset, but this seems to be a blocker).

Attachments (0)

Change History (4)

comment:1 Changed 3 months ago by SimonPoole

BTW the use of "main" to indicate the normal local water supply is very suspect, the correct term would be "mains".

comment:2 Changed 3 months ago by Don-vip

Cc: Klumbumbus added

for reference: #15774 / r14593

comment:3 Changed 3 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14608/josm:

fix #17149, see #15774 - remove couplings:type from hydrant preset due to suspect values

comment:4 Changed 3 months ago by Klumbumbus

Milestone: 18.12

Removed couplings:type for now until tagging clarification. I didn't change main to mains as mains is used 0 times and I didn't remove it as well as the combo is incomplete without that value which would be even worse.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.