Modify

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#17130 closed enhancement (fixed)

Complain about area:highway on open ways and nodes

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 18.12
Component: Core validator Version:
Keywords: template_report Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Create node and tag it with area:highway=footway
  2. Create open way and tag it with area:highway=footway
  3. Run validator

What is the expected result?

Validator complain about area:highway=* that is not on areas.

What happens instead?

No complaints.

Please provide any additional information below. Attach a screenshot if possible.

https://wiki.openstreetmap.org/wiki/Key:area:highway

for example that would make detective work in https://www.openstreetmap.org/changeset/65649382 https://www.openstreetmap.org/changeset/65648467 https://www.openstreetmap.org/changeset/65648437 much,much easier

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-12-17 22:42:01 +0100 (Mon, 17 Dec 2018)
Build-Date:2018-12-18 02:32:19
Revision:14575
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14575 en) Linux Ubuntu 16.04.5 LTS
Memory Usage: 435 MB / 869 MB (192 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34535)
+ buildings_tools (34724)
+ continuosDownload (82)
+ imagery_offset_db (34641)
+ measurement (34529)
+ reverter (34552)
+ todo (30306)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (1)

area_highway test.osm (1.1 KB) - added by mkoniecz 2 months ago.

Download all attachments as: .zip

Change History (6)

Changed 2 months ago by mkoniecz

Attachment: area_highway test.osm added

comment:1 Changed 2 months ago by mkoniecz

Description: modified (diff)

comment:2 Changed 2 months ago by Klumbumbus

Milestone: 18.12

Someone please check the following patch. I didn't test the change in UnclosedWays.java (I have not yet setup my compiling again).

  • data/validator/geometry.mapcss

     
    5757node[golf=bunker],
    5858node[golf=fairway],
    5959node[area=yes],
     60node[area:highway],
    6061node[landuse],
    6162node[natural=scree],
    6263node[natural=scrub],
  • src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java

     
    152152        new UnclosedWaysCheck(1108, "waterway",  marktr("waterway type {0}"),
    153153                new HashSet<>(Arrays.asList("riverbank")), false),
    154154        new UnclosedWaysCheck(1109, "boundary", marktr("boundary type {0}")),
     155        new UnclosedWaysCheck(1110, "area:highway", marktr("area:highway type {0}")),
    155156        new UnclosedWaysBooleanCheck(1120, "building", marktr("building")),
    156157        new UnclosedWaysBooleanCheck(1130, "area",     marktr("area")),
    157158        // CHECKSTYLE.ON: SingleSpaceSeparator

comment:3 Changed 2 months ago by Don-vip

It works as expected, we got two warnings (one for the node, one for the open way).

comment:4 Changed 2 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14577/josm:

fix #17130 - warn about area:highway on unclosed ways and nodes

comment:5 Changed 2 months ago by Klumbumbus

Thanks for testing.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.