[RFC][PATCH] Include shop=gas in the presets

[naoliv]

Include ​shop=gas

data/defaultpresets.xml

@@ -9880 +9880 @@
             <reference ref="name_operator_oh_wheelchair" />
             <reference ref="link_contact_address_payment" />
         </item> <!-- Paint -->
+        <item name="Gas" icon="presets/shop/gas.svg" type="node,closedway,multipolygon" preset_name_label="true">
+            <link href="https://wiki.openstreetmap.org/wiki/Tag:shop=gas"
+                  cs.href="https://wiki.openstreetmap.org/wiki/Cs:Tag:shop=gas"
+                  de.href="https://wiki.openstreetmap.org/wiki/DE:Tag:shop=gas"
+                  es.href="https://wiki.openstreetmap.org/wiki/ES:Tag:shop=gas"
+                  ja.href="https://wiki.openstreetmap.org/wiki/JA:Tag:shop=gas"
+                  pl.href="https://wiki.openstreetmap.org/wiki/Pl:Tag:shop=gas"
+                  pt.href="https://wiki.openstreetmap.org/wiki/Pt:Tag:shop=gas"
+                  ru.href="https://wiki.openstreetmap.org/wiki/RU:Tag:shop=gas" />
+            <space />
+            <key key="shop" value="gas" />
+            <reference ref="name_operator_oh_wheelchair" />
+            <reference ref="link_contact_address_payment" />
+        </item> <!-- Gas -->
         <separator/>
         <item name="Travel Agency" icon="presets/shop/travel_agency.svg" type="node,closedway,multipolygon" preset_name_label="true">
             <link href="https://wiki.openstreetmap.org/wiki/Tag:shop=travel_agency"

styles/standard/elemstyles.mapcss

@@ -2117 +2117 @@
     icon-image: "presets/shop/frame.svg";
     set icon_z17;
 }
+node[shop=gas] {
+    icon-image: "presets/shop/gas.svg";
+    set icon_z17;
+}
 node[shop=gift] {
     icon-image: "presets/shop/present.svg";
     set icon_z17;

Icon:

Preset:

SVG is attached and was sketched out by me (so you can consider it CC0 and/or PD, choose what's best and modify as needded).

[Klumbumbus]

In 14575/josm:

fix #17120 - add shop=gas (patch by naoliv, icon by naoliv, modified, CC0 and PD licensed)

[Klumbumbus]

Thanks for the patch! Some small things I changed:

• added the rendering for areas
• changed floating viewbox values of the icon to integer numbers (causes resizing and therefore unsharp icons, see wiki:/DevelopersGuide/DefaultPresets)
• changed the size from 16x16 to 16x11
• pixelaligned back the upper part as it became unsharp by the viewbox values fix.

Here are the adjustment steps of the icon:

[naoliv]

Great!
Thank you!

[Don-vip]

We have TagCheckerTest.testShortValNotInPreset2 failing since r14575.

[Don-vip]

Wait, we considered "gas" to be a mispelled value?

    /**
     * Check for misspelled value.
     * @throws IOException if any I/O error occurs
     */
    @Test
    public void testShortValNotInPreset2() throws IOException {
        final List<TestError> errors = test(OsmUtils.createPrimitive("node shop=gas"));
        assertEquals(1, errors.size());
        assertEquals("Presets do not contain property value", errors.get(0).getMessage());
        assertEquals("Value 'gas' for key 'shop' not in presets.", errors.get(0).getDescription());
        assertEquals(Severity.OTHER, errors.get(0).getSeverity());
        assertFalse(errors.get(0).isFixable());
    }

[Don-vip]

Added in r14571 :) Please find a new value for the test :)

[GerdP]

In 14579/josm:

see #17120: fix unit test: shop=gas was added to presets, use shop=abs instead

Hope this will never make it into the presets...