Modify

Opened 4 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#17116 closed defect (fixed)

Missing translation for "No tile at this zoom level"

Reported by: naoliv Owned by: team
Priority: normal Milestone: 18.12
Component: Core imagery Version:
Keywords: i18n Cc:

Description

Even with the string properly translated in launchpad we still see an unstranslated No tile at this zoom level message:

https://i.imgur.com/xMOJDti.png

I did try this without success (the message in English is still appearing):

  • src/org/openstreetmap/gui/jmapviewer/OsmTileLoader.java

    diff --git a/src/org/openstreetmap/gui/jmapviewer/OsmTileLoader.java b/src/org/openstreetmap/gui/jmapviewer/OsmTileLoader.java
    index b2b359c1e..7144ff913 100644
    a b  
    11// License: GPL. For details, see Readme.txt file.
    22package org.openstreetmap.gui.jmapviewer;
    33
     4import static org.openstreetmap.gui.jmapviewer.FeatureAdapter.tr;
     5
    46import java.io.IOException;
    57import java.io.InputStream;
    68import java.net.HttpURLConnection;
    public class OsmTileLoader implements TileLoader { 
    4951                }
    5052                loadTileMetadata(tile, conn);
    5153                if ("no-tile".equals(tile.getValue("tile-info"))) {
    52                     tile.setError("No tile at this zoom level");
     54                    tile.setError(tr("No tile at this zoom level"));
    5355                } else {
    5456                    input = conn.getInputStream();
    5557                    try {
  • src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java

    diff --git a/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java b/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java
    index b97112f05..974ee7789 100644
    a b public class TMSCachedTileLoaderJob extends JCSCachedTileLoaderJob<String, Buffe 
    278278    private boolean handleNoTileAtZoom() {
    279279        if (isNoTileAtZoom()) {
    280280            Logging.debug("JCS TMS - Tile valid, but no file, as no tiles at this level {0}", tile);
    281             tile.setError("No tile at this zoom level");
     281            tile.setError(tr("No tile at this zoom level"));
    282282            tile.putValue("tile-info", "no-tile");
    283283            return true;
    284284        }

JOSM:

Revision:14569
Is-Local-Build:true
Build-Date:2018-12-17 00:38:03

Identification: JOSM/1.5 (14569 SVN pt_BR) Linux Debian GNU/Linux buster/sid
Memory Usage: 392 MB / 2048 MB (194 MB allocated, but free)
Java version: 11.0.1+13-Debian-3, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.1+13-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-21
VM arguments: [-Dawt.useSystemAAFontSettings=gasp]

Attachments (0)

Change History (7)

comment:1 Changed 4 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 14570/josm:

fix #17116 - translate "No tile at this zoom level"

comment:2 Changed 4 weeks ago by Don-vip

Component: CoreCore imagery
Keywords: i18n added
Milestone: 18.12

comment:3 Changed 4 weeks ago by Don-vip

Note: it should probably work only after the next i18n update.

comment:4 Changed 4 weeks ago by naoliv

Ah... it seems that I didn't pay attention and didn't realize that the translation that already exists has tiles instead of tile
https://i.imgur.com/QtTrVq0.png

That's why I wasn't seeing the translation :-)
Thanks!

comment:5 Changed 4 weeks ago by Don-vip

Ah. We should only keep one string.

comment:6 Changed 4 weeks ago by Don-vip

In 14573/josm:

see #17116 - use existing translated string

comment:7 Changed 4 weeks ago by stoecker

"No tiles" for a single tile would be wrong. I'd say this is one of the few cases, where similar strings are ok...

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.