Modify

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#17115 closed enhancement (fixed)

[PATCH] update crane preset

Reported by: naoliv Owned by: team
Priority: normal Milestone: 18.12
Component: Internal preset Version:
Keywords: Cc:

Description (last modified by Klumbumbus)

osmwiki:Tag:man_made=crane
osmwiki:Key:crane:type

  • data/defaultpresets.xml

    diff --git a/data/defaultpresets.xml b/data/defaultpresets.xml
    index 9a369d809..ec779dda4 100644
    a b  
    75967596                  ru.href="https://wiki.openstreetmap.org/wiki/RU:Tag:man_made=crane" />
    75977597            <space />
    75987598            <key key="man_made" value="crane" />
    7599             <text key="name" text="Name" />
     7599            <optional>
     7600                <combo key="crane:type" text="Type" values="floor-mounted_crane,gantry_crane,portal_crane,travel_lift" />
     7601                <combo key="crane:mobile" text="Mobility" values="no,rail,street,work_site" />
     7602                <reference ref="name_operator" />
     7603            </optional>
    76007604        </item> <!-- Crane -->
    76017605        <item name="Mineshaft" icon="presets/landmark/mine.svg" type="node,closedway" preset_name_label="true">
    76027606            <link href="https://wiki.openstreetmap.org/wiki/Tag:man_made=mineshaft"

Attachments (0)

Change History (2)

comment:1 Changed 2 months ago by Klumbumbus

Description: modified (diff)
Milestone: 18.12

I don't like the crane:mobile tag:

  • Is "mobile" proper english? Shouldn't it be "mobility"?
  • If a crane is movable on streets or at the whole work_site then it is no longer a "stationary, permanent crane,that [...] may be movable in a restricted area" which is the definition of man_made=crane. Thus these two values are invalid and such cranes shouldn't be mapped at all.
  • Other values than "rail" are not really widely used. https://taginfo.openstreetmap.org/keys/?key=crane%3Amobile#values
  • The values are not explained in the wiki.

OK for the other changes.

Last edited 2 months ago by Klumbumbus (previous) (diff)

comment:2 Changed 2 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14574/josm:

fix #17115 - enhance crane preset (patch by naoliv)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.