Opened 6 years ago
Closed 6 years ago
#17101 closed enhancement (wontfix)
Validation should cache older results
Reported by: | taylor.smock | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | Cc: |
Description
Instead of rerunning validation for the entire download(s), JOSM should cache older results and only run newly enabled/modified checks and checks on modified areas.
Current workflow:
1) Run a validation of a large area
2) Fix an error/warning
3) Upload
4a) If there are no errors on the upload, keep current validation results
4b) If there is an error on the upload, clear current validation results and show new validation results
If 4a: Start at step 2 again
If 4b:
5) Rerun validation, with validation taking (roughly) the same amount of time as the first run, getting largely the same results.
Ideal workflow:
5) Rerun validation, with the validator loading the old results and only rerunning validation on possibly modified sections and running newly enabled validation checks. Maybe only do this when there are more than X objects?
Note: I've probably worded this poorly, but I would like to avoid running duplicate validation checks.
Current workaround: disable check on upload for every check (not ideal)
Attachments (0)
Change History (2)
comment:1 by , 6 years ago
- I also don't like that the results of the last "complete validation" is lost when you validate a single object (or a selection) or when try to upload. A possible solution might be to keep a history of validation results.
- I see no way to implement 5)
- Besides that you might want to change your workflow. I also sometimes execute the validator on a large area. When I want to fix something I zoom to that area and download it in a new layer. In that layer I try to fix the problem and validation is done quickly. When done, I close the layer and maybe download the data in the zoomed area again to update. This works well for me.
comment:2 by , 6 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
You both know that the validator checks the current selection, do you? So you simply needs to select the elements of an area to reduce the time the validator takes (i.e. by drawing a selection rectangle around the area).
Keeping history of validation is not a good idea, as changing a single object can influence others. To keep track of that is nearly impossible. Already the fix and remove features we have now are dangerous because they don't care for such things.