Imagery menu broken in 14533

[donnersbergsiedlung@…]

What steps will reproduce the problem?

1. Start JOSM
2. Download any area
3. Attempt to open the Imagery menu

What is the expected result?

Imagery menu will pop up

What happens instead?

Attached error pops up. If selected to ignore all errors in the current session, selected imagery will multiply itself in the menu for every time you open the Imagery menu.

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2018-12-09 18:47:31
Revision:14533
Is-Local-Build:true

Identification: JOSM/1.5 (14533 SVN de) Windows 7 64-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 692 MB / 1810 MB (559 MB allocated, but free)
Java version: 1.8.0_171-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ reverter (34552)
+ terracer (34584)
+ utilsplugin2 (34770)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Handled by bug report queue: java.lang.NoSuchMethodError: org.openstreetmap.josm.tools.Geometry.nodeInsidePolygon(Lorg/openstreetmap/josm/data/osm/Node;Ljava/util/List;)Z


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (17) of main
java.lang.NoSuchMethodError: org.openstreetmap.josm.tools.Geometry.nodeInsidePolygon(Lorg/openstreetmap/josm/data/osm/Node;Ljava/util/List;)Z
	at org.openstreetmap.josm.data.imagery.Shape.contains(Shape.java:67)
	at org.openstreetmap.josm.gui.ImageryMenu.refreshImageryMenu(ImageryMenu.java:180)
	at org.openstreetmap.josm.gui.ImageryMenu$1.menuSelected(ImageryMenu.java:118)
	at javax.swing.JMenu.fireMenuSelected(Unknown Source)
	at javax.swing.JMenu$MenuChangeListener.stateChanged(Unknown Source)
	at javax.swing.DefaultButtonModel.fireStateChanged(Unknown Source)
	at javax.swing.DefaultButtonModel.setSelected(Unknown Source)
	at javax.swing.JMenu.setSelected(Unknown Source)
	at javax.swing.JMenu.menuSelectionChanged(Unknown Source)
	at javax.swing.MenuSelectionManager.setSelectedPath(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuUI$Handler.mousePressed(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuUI$MouseInputHandler.mousePressed(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[GerdP]

Can't reproduce it. Please try to build with

ant clean dist

[donnersbergsiedlung@…]

Seems to work with ant clean dist.

The wiki page https://josm.openstreetmap.de/wiki/Source_code should be changed to reflect this. https://josm.openstreetmap.de/wiki/DevelopersGuide/CreateBuild already has the correct steps, the other page doesn't (strangely).

[donnersbergsiedlung@…]

Correct link should be: https://josm.openstreetmap.de/wiki/Source%20code (spaces are hard)

[GerdP]

When you use svn co to checkout a clean copy there is no need to use ant clean. If you do svn up or manual edits
a simple ant build should work. Anyhow, if you see a NoSuchMethodError it is a good idea to use ant clean dist