Modify

Opened 5 years ago

Last modified 4 years ago

#17078 new enhancement

[PATCH] update clothes in preset

Reported by: naoliv Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: Cc:

Description

Include clothes=* in the shop=clothes preset and, as a bonus, also update the keys in Motorcycle Dealer.

From this:

https://i.imgur.com/lAzlpHa.png https://i.imgur.com/CdqnVFx.png

We now have this:

https://i.imgur.com/Z9MjgeO.png https://i.imgur.com/uxqKXgI.png

Ugly Motorcycle Dealer preset due to #17077; unsure if there is a better way to do this.

  • data/defaultpresets.xml

    diff --git a/data/defaultpresets.xml b/data/defaultpresets.xml
    index 23b13a97b..7e29ee731 100644
    a b  
    36413641            <reference ref="motorcycle_brands" />
    36423642            <text key="operator" text="Operator" />
    36433643            <reference ref="oh_wheelchair" />
    3644             <combo key="second_hand" text="Second hand" values="only,yes,no" />
    36453644            <optional text="Services:">
    3646                 <combo key="sale" text="Sale" values="yes,brand,no" />
    3647                 <combo key="rental" text="Rental" values="yes,brand,no" />
    3648                 <combo key="repair" text="Repair" values="yes,brand,oldtimer,no" />
    3649                 <combo key="safety_inspection" text="Safety inspection" values="yes,DEKRA,GTÜ,MOT,TÜV,no" />
    3650                 <combo key="parts" text="Parts" values="yes,brand,oldtimer,no" />
    3651                 <combo key="clothes" text="Clothes" values="yes,brand,no" />
    3652                 <text key="services" text="Other" />
     3645                <multiselect key="motorcycle:sales" text="Sale" values="yes;used" />
     3646                <multiselect key="motorcycle:rental" text="Rental" values="yes;trailer" />
     3647                <multiselect key="motorcycle:parts" text="Parts" values="yes;brand;custom;exhaust;luggage;sidecar" />
     3648                <multiselect key="motorcycle:type" text="Type" values="standard;dualsport;offroad;chopper;sportbike;scooter;all;electric" />
     3649                <check key="motorcycle:repair" text="Repair" />
     3650                <check key="motorcycle:tyres" text="Tyres" />
     3651                <check key="motorcycle:clothes" text="Clothes" />
    36533652            </optional>
    36543653            <reference ref="link_contact_address_payment" />
    36553654        </item> <!-- Motorcycle Dealer -->
     
    90649063            <space />
    90659064            <key key="shop" value="clothes" />
    90669065            <reference ref="name_oh_wheelchair" />
     9066            <multiselect key="clothes" text="Clothes" values="babies;children;costumes;denim;fashion;fur;hats;leather;maternity;men;oversize;schoolwear;sports;suits;swimwear;traditional;underwear;wedding;women;workwear" />
    90679067            <combo key="second_hand" text="Second hand" values="only,yes,no" />
    90689068            <combo key="organic" text="Organic" values="only,yes,no" />
    90699069            <reference ref="link_contact_address_payment" />

Attachments (0)

Change History (4)

comment:1 by Klumbumbus, 5 years ago

clothes=* was discussed in the past at #11245

comment:2 by naoliv, 5 years ago

From 4 years ago the usage has increased:

https://i.imgur.com/1DKh4zf.png

iD and Vespucci (search for <chunk id="clothes"> at https://raw.githubusercontent.com/simonpoole/beautified-JOSM-preset/master/master_preset.xml) also support it at their presets.

comment:3 by skyper, 4 years ago

A solution would be to sort out the gender/age to cloth:for=children/women/men and leave cloth=* for the type of clothing.

comment:4 by Klumbumbus, 4 years ago

clothes was added, see #11245. Not sure about the current status of the different tagging schemas with and without motorcycle: prefix

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to naoliv.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.