Modify

Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#17077 closed enhancement (worksforme)

Better display multiselect boxes with few values

Reported by: naoliv Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: presets multiselect Cc:

Description

Have <multiselect key="motorcycle:sales" text="Sale" values="yes;used" /> in a preset (where we can select yes, used or both values):

https://i.imgur.com/uxqKXgI.png

Couldn't the box be resized to better fit the content, specially when we have a small amount of values?

JOSM:

Revision:14516
Is-Local-Build:true
Build-Date:2018-12-05 21:05:37

Identification: JOSM/1.5 (14516 SVN pt_BR) Linux Debian GNU/Linux buster/sid
Memory Usage: 352 MB / 2048 MB (187 MB allocated, but free)
Java version: 11.0.1+13-Debian-3, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.1+13-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-21
VM arguments: [-Dawt.useSystemAAFontSettings=gasp]

Plugins:
+ BuildingGeneralization (23)
+ EasyPresets (1537621333)
+ ImportImagePlugin (34576)
+ OpeningHoursEditor (34535)
+ SimplifyArea (34586)
+ apache-commons (34506)
+ buildings_tools (34724)
+ download_along (34503)
+ editgpx (34751)
+ ejml (34389)
+ geojson (87)
+ geotools (34513)
+ jaxb (34506)
+ jogl (1.2.2)
+ jts (34524)
+ log4j (34527)
+ measurement (34529)
+ merge-overlap (34664)
+ opendata (34698)
+ poly (34546)
+ reverter (34552)
+ tageditor (34560)
+ tagging-preset-tester (34561)
+ todo (30306)
+ turnlanes-tagging (272)
+ turnrestrictions (34643)
+ undelete (34568)
+ utilsplugin2 (34506)
+ wikipedia (v1.1.1)

Attachments (0)

Change History (7)

comment:1 by simon04, 5 years ago

Keywords: presets multiselect added
Type: defectenhancement

You can specify rows="2", already, see TaggingPresets#Attributes.

comment:2 by Klumbumbus, 5 years ago

Resolution: fixed
Status: newclosed

So we can close this ticket as worksforme or do you plan to do some enhancement? The open issue is #19013.

comment:3 by skyper, 5 years ago

Enhancement would be to auto-shrink if row is not present and the number of values is below the default value for rows.

Version 1, edited 5 years ago by skyper (previous) (next) (diff)

comment:4 by Klumbumbus, 5 years ago

Resolution: fixed
Status: closedreopened

Oops, I didn't want to close it during comment:2

comment:5 by simon04, 5 years ago

The problem is that there's no "default value for rows" – it depends on the look and feel in use. We could just guess (and be wrong sometimes). I favour the explicit variant.

comment:6 by skyper, 5 years ago

Resolution: fixed
Status: reopenedclosed

Then there is nothing left to do, as Klumbumbus updated the defaultpresets in r16482.

comment:7 by Klumbumbus, 5 years ago

Resolution: fixedworksforme

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.