Modify

Opened 4 months ago

Closed 4 months ago

Last modified 2 months ago

#17054 closed enhancement (fixed)

slippy map in the download dialogue should not default to the non-standard imagery provider "Mapnik"

Reported by: aseerel4c26 Owned by: Don-vip
Priority: minor Milestone: 18.12
Component: Core Version:
Keywords: download imagery Cc:

Description (last modified by Don-vip)

The slippy map in the download dialogue defaults to a imagery named "Mapnik" which is not listed in the default imagery provider list. It still works and downloads the standard tiles from osm.org.

Mapnik entry in selection menu

This should default to the standard imagery provider "OpenStreetMap Carto (Standard)". Advantages:

  1. bandwidth savings if the user uses the "OpenStreetMap Carto (Standard)" as background layer AND uses the download dialogue.
  2. no ghost "Mapnik" entry in the Cache contents tab - it may be not obvious where this entry stems from since "Mapnik" is no imagery provider.

Or is there any reason to stick with the old "Mapnik"? I guess it is just a left-over from the standard imagery name (before it was renamed to Carto).

Tested with deleted config and cache directory.
Identification: JOSM/1.5 (14460 en_GB) Linux Linux
Java version: 10.0.2+13, Oracle Corporation, OpenJDK 64-Bit Server VM

Attachments (1)

Screenshot_20181201_105716.png (36.5 KB) - added by aseerel4c26 4 months ago.
Mapnik entry in selection menu

Download all attachments as: .zip

Change History (12)

Changed 4 months ago by aseerel4c26

Mapnik entry in selection menu

comment:1 Changed 4 months ago by Don-vip

Description: modified (diff)

comment:2 Changed 4 months ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned

comment:3 Changed 4 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 14495/josm:

fix #17054 - prefer JOSM imagery entry "OpenStreetMap Carto (Standard)" over jmapviewer tile source "Mapnik"

comment:4 Changed 4 months ago by aseerel4c26

Thanks, perfect! :-) Tested with v14500 and fresh config: both "Advantages" work. "Mapnik" only comes back if I delete "OpenStreetMap Carto (Standard)" from my tiles list.

comment:5 Changed 4 months ago by Klumbumbus

I added oldid, maybe that helps to clean up old remaining mapnik entries. https://josm.openstreetmap.de/wiki/Maps/Worldwide?action=diff&version=41

comment:6 Changed 4 months ago by stoecker

Wont help. I think jmapviewer defaults simply should be updated...

comment:7 Changed 4 months ago by Don-vip

that's unrelated, I didn't even know we had an entry with id "MAPNIK" before. The "Mapnik" entry des not come from Maps, it's a Java class that comes from JMapViewer.

comment:8 Changed 4 months ago by stoecker

Updated defaults in [o34765].

comment:10 Changed 4 months ago by Don-vip

Fixed in [o34766].

comment:11 Changed 2 months ago by Don-vip

Milestone: 18.12

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.